Skip to content

fix: changing ubuntu and macOS image to Latest#7582

Merged
v-sharmachir merged 3 commits intomainfrom
users/v-sharmachir/ubuntu
May 7, 2025
Merged

fix: changing ubuntu and macOS image to Latest#7582
v-sharmachir merged 3 commits intomainfrom
users/v-sharmachir/ubuntu

Conversation

@v-sharmachir
Copy link
Copy Markdown
Contributor

@v-sharmachir v-sharmachir commented Apr 21, 2025 •
edited
Loading

Details

  1. Ubuntu 20.04 LTS runner is removed on 2025-04-15 and causing failure in github action workflow. Changed the runner to ubuntu-22.04 to avoid future failures.
  2. Changing macOS-11 to macOS-14 to fix build pipeline issues. https://dev.azure.com/accessibility-insights/accessibility-insights-web/_build/results?buildId=58431&view=results
Motivation
Context

CI failure is unrelated, see #7323.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@v-sharmachir v-sharmachir changed the title changing ubuntu image to Latest fix: changing ubuntu image to Latest Apr 21, 2025
@v-sharmachir v-sharmachir marked this pull request as ready for review April 21, 2025 07:02
@v-sharmachir v-sharmachir requested a review from a team as a code owner April 21, 2025 07:02
@v-sharmachir v-sharmachir marked this pull request as draft April 21, 2025 12:28
@v-sharmachir v-sharmachir changed the title fix: changing ubuntu image to Latest fix: changing ubuntu and macOS image to Latest Apr 21, 2025
@v-viyada v-viyada marked this pull request as ready for review April 21, 2025 19:39
@katharinakoal
Copy link
Copy Markdown

katharinakoal commented May 5, 2025

Thank you for identifying the outdated runners! I believe we should pin them to a newer, specific version. Using the latest available version makes CI runs non-deterministic and risks silently introducing breaking changes.

@v-sharmachir
Copy link
Copy Markdown
Contributor Author

v-sharmachir commented May 6, 2025

Hi @katharinakoal, updated the newer specific version. Please re-review.

katharinakoal
katharinakoal approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown

@katharinakoal katharinakoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of this.

@v-sharmachir v-sharmachir merged commit 91684f0 into main May 7, 2025
13 checks passed
@v-sharmachir v-sharmachir deleted the users/v-sharmachir/ubuntu branch May 7, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katharinakoal katharinakoal katharinakoal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-sharmachir @katharinakoal