Details

Typescript Cleanup Part 3 of 3
Covering 80 errors in 40 files in this PR

Motivation

SUBPART 1:

1. src/tests/unit/tests/common/configs/web-visualization-configuration-factory.test.ts (4)
2. src/tests/unit/tests/DetailsView/actions/assessment-action-message-creator.test.ts (4)
3. src/tests/unit/tests/DetailsView/components/assessment-issues-test-view.test.tsx (6)
4. src/tests/unit/tests/DetailsView/components/test-view-container.test.tsx (1)
5. src/tests/unit/tests/DetailsView/details-view-body.test.tsx (1)
6. src/tests/unit/tests/DetailsView/details-view-content.test.tsx (3)
7. src/tests/unit/tests/DetailsView/document-title-updater.test.ts (1)
8. src/tests/unit/tests/DetailsView/handlers/get-document-title.test.ts (2)
9. src/tests/unit/tests/DetailsView/components/left-nav/details-view-left-nav.test.tsx (1)
10. src/tests/unit/tests/DetailsView/components/next-requirement-button.test.tsx (1)
11. src/tests/unit/tests/DetailsView/components/scan-incomplete-warning.test.tsx (1)

Number of errors covered as part of this user story: 25

SUBPART 2:

Merged PR2 which had these files fixed:
v-prachin#1

1. src/tests/unit/tests/injected/analyzer-state-update-handler.test.ts (5)
2. src/tests/unit/tests/injected/analyzers/analyzer-provider.test.ts (1)
3. src/tests/unit/tests/injected/analyzers/tab-stops-analyzer.test.ts (1)
4. src/tests/unit/tests/injected/selector-map-helper.test.ts (4)
5. src/tests/unit/tests/injected/target-page-visualization-updater.test.ts (1)
6. src/tests/unit/tests/injected/visualization-state-change-handler.test.ts (2)
7. src/tests/unit/tests/injected/visualization-type-drawer-registrar.test.ts (1)
8. src/tests/unit/tests/popup/components/diagnostic-view-toggle-factory.test.tsx (8)
9. src/tests/unit/tests/background/stores/visualization-scan-result-store.test.ts (2)

Number of errors covered as part of this user story: 25

SUBPART 3:

1. src/tests/unit/tests/DetailsView/components/adhoc-static-test-view.test.tsx (1)
2. src/tests/unit/tests/DetailsView/components/adhoc-tab-stops-test-view.test.tsx (1)
3. src/tests/unit/tests/DetailsView/components/iframe-warning.test.tsx (2)
4. src/tests/unit/tests/DetailsView/components/issues-table.test.tsx (1)
5. src/tests/unit/tests/DetailsView/details-view-container.test.tsx (2)
6. src/tests/unit/tests/injected/adapters/resolution-creator.test.ts (1)
7. src/tests/unit/tests/reports/package/axe-results-report.test.ts (1)
8. src/tests/unit/tests/background/target-tab-controller.test.ts (1)
9. src/tests/unit/tests/background/stores/persistent-store.test.ts (1)
10. src/tests/unit/tests/DetailsView/components/adhoc-issues-test-view.test.tsx(1)
11. src/tests/unit/tests/background/initial-visualization-store-data-generator.test.ts (2)
12. src/tests/unit/tests/reports/components/inline-image.test.tsx (1)
13. src/tests/unit/tests/common/message-creators/assessment-card-selection-message-creator.test.ts
14. src/tests/unit/tests/common/message-creators/card-selection-message-creator.test.ts
15. src/tests/unit/tests/common/message-creators/needs-review-card-selection-message-creator.test.ts
16. src/tests/unit/tests/common/notification-creator.test.ts
17. src/tests/unit/tests/common/telemetry-data-factory.test.ts
18. src/tests/unit/tests/DetailsView/actions/details-view-action-message-creator.test.ts
19. src/tests/unit/tests/DetailsView/actions/tab-stop-requirement-action-message-creator.test.ts
20. src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx

Number of errors covered as part of this user story: 30

Total Number of errors covered as part of this user story: 80

• src/common/components/cards/instance-details-group.tsx

• src/DetailsView/details-view-initializer.ts

Due to typescript changes the style of the snapshot file got re-arranged. So updated the snapshot files.

Context

Pull request checklist

• Addresses an existing issue: #(chore: Remove deprecated TypeScript options #6611)
• Ran yarn fastpass
• Added/updated relevant unit test(s) (and ran yarn test)
• Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
• PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
• [n/a] (UI changes only) Added screenshots/GIFs to description above
• [n/a] (UI changes only) Verified usability with NVDA/JAWS