chore: Typescript Cleanup Part 2 of 3 for order, x:left, pageTitle, requirement, titleSize="title & defaultViewport: null#7280
Merged
v-prachin merged 8 commits intomicrosoft:mainfrom Apr 8, 2024
Conversation
madalynrose
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Typescript Cleanup Part 2 of 3
We have total 140 errors in 104 files. Thus, targeting each error and fixing it.
Motivation
Errors observed in below files observed after removing deprecated properties from tsconfig file:
1.order:0
src/issue-filing/services/null-issue-filing-service/null-issue-filing-service.tsx
Removed this property as NullIssueFilingService has this order property which seems to be not consumed, as per my understanding. As checked for the references order: and couldn't observe anything relevant to NullIssueFilingService.
2.titleSize="title"
src/reports/components/report-sections/combined-report-rules-only-sections.tsx (1)
Removed this property as CombinedReportResultSectionTitle in other files only has three entities in it, outcomeCount,
outcomeType, title. That file is combined-report-failed-section.tsx
3.defaultViewport: null
src/tests/end-to-end/common/browser-factory.ts (1)
Removed this property as defaultViewport has only one reference in the entire solution and that is in brower-factory.ts
4.requirement: requirementKey
src/tests/unit/tests/background/stores/assessment-store.test.ts (3)
Added appropriate interface for requirement & selector properties.
5.pageTitle
src/tests/unit/tests/reports/components/fast-pass-report-automated-checks-results.test.tsx (1)
src/tests/unit/tests/reports/components/fast-pass-report.test.tsx (1)
Removed this property as it was not needed in the test file.
6.x:left
src/injected/visualization/drawer-utils.ts (1)
Removed this property as BoundingRect already has left and top properties defined.
Thus, total number of errors covered as part of this user story: 9
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.