chore: Typescript Cleanup- Part 2 for Test Files #7269
Merged
JeevaniChinthala merged 3 commits intomainfrom Apr 1, 2024
Merged
chore: Typescript Cleanup- Part 2 for Test Files #7269JeevaniChinthala merged 3 commits intomainfrom
JeevaniChinthala merged 3 commits intomainfrom
Conversation
DaveTryon
approved these changes
Mar 18, 2024
Contributor
DaveTryon
left a comment
There was a problem hiding this comment.
These changes look good to me. None of the deleted properties exist in the type definitions, and since we're dealing almost exclusively with test code, the risk seems very low.
That said, I'd love to get a second review on these changes.
madalynrose
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
As part of Typescript migration added/removed the error causing fields. As most of the files are test cases which were removed from actual file but not updated the test case files.
Motivation
TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5
Context
1. displayName: 'JSON'
2. columnConfiguration: []
3. noClick
4. newTab: newTab
5. showAssessment: true
Object literal may only specify known properties, and 'showAssessment' does not exist in type 'StartOverContextMenuKeyOptions'.
6. status: 'fail'
7. highlightState: 'hidden
8. fixInstructionProcessor
9. showCongratsIfNotInstances: true
10. iconName="test icon"
11. selectedTest: VisualizationType[-1]
12. requirementName
Object literal may only specify known properties, and 'requirementName' does not exist in type 'RuleAnalyzerScanTelemetryData'.
13. status: ManualTestStatus.FAIL,
14. featureFlagStoreData: {},
15. userConfigurationStoreData
16. featureFlagStoreData: {},
17. shortcutModifyHandler
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.