Skip to content

chore: Typescript Cleanup- Part 1 of 3#7255

Merged
SaanicaG merged 2 commits intomicrosoft:mainfrom
SaanicaG:v-sghate/Typescript_Deprecation_Assessment
Mar 7, 2024
Merged

chore: Typescript Cleanup- Part 1 of 3#7255
SaanicaG merged 2 commits intomicrosoft:mainfrom
SaanicaG:v-sghate/Typescript_Deprecation_Assessment

Conversation

@SaanicaG
Copy link
Copy Markdown
Contributor

@SaanicaG SaanicaG commented Feb 29, 2024

Details

As part of Typescript migration added/removed the error causing fields.

  1. src/DetailsView/components/details-view-content.tsx
  • For the above file we were getting errors on getOverviewHeadingIntro, linkDataSource, getOverviewHelpSectionAbout these properties.
  • These properties are referred in details-view-switcher-nav.ts, overview-content-container.tsx.
  • Hence, we are not removing these properties, and added it in details-view-body.tsx.
  1. src/DetailsView/components/details-view-overlay/scoping-panel/scoping-panel.tsx
  • We were getting error on deps={this.props.deps}.
  • In details-view-overlay.tsx class ScopingPanel is used.
  • Hence, we are not removing these properties and added it in scoping-container.tsx
  1. Details-view-switcher-nav.ts
  • Got error on shouldShowQuickAssessRequirementView: true,
  • Couldn’t find any reference to the above property in any of the files.
  • Tested it after removing the property. There are no errors and also on UI level couldnt find any issues.
    -Hence, it seems like it is safe to remove it.
Motivation

TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5

Associated User story - User Story 2151430

Context

Pull request checklist

  • Addresses an existing issue: #(chore: Remove deprecated TypeScript options #6611)
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@SaanicaG SaanicaG changed the title typescript file fixes chore: Typescript Cleanup- Part 3 of 1 for Errors status,tooltip,selectedtest Feb 29, 2024
@SaanicaG SaanicaG changed the title chore: Typescript Cleanup- Part 3 of 1 for Errors status,tooltip,selectedtest chore: Typescript Cleanup- Part 3 of 1 Feb 29, 2024
@SaanicaG SaanicaG changed the title chore: Typescript Cleanup- Part 3 of 1 chore: Typescript Cleanup- Part 1 of 3 Feb 29, 2024
@v-viyada v-viyada marked this pull request as ready for review March 5, 2024 17:06
@v-viyada v-viyada requested a review from a team as a code owner March 5, 2024 17:06
Copy link
Copy Markdown
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaanicaG SaanicaG merged commit b4363a2 into microsoft:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants