chore: Enzyme replacement in test files- PR 1 of 6 for part 3 of 3#7232
Merged
v-singhanjal merged 18 commits intomicrosoft:mainfrom Mar 5, 2024
Merged
chore: Enzyme replacement in test files- PR 1 of 6 for part 3 of 3#7232v-singhanjal merged 18 commits intomicrosoft:mainfrom
v-singhanjal merged 18 commits intomicrosoft:mainfrom
Conversation
v-rakeshsh
reviewed
Feb 5, 2024
v-rakeshsh
reviewed
Feb 5, 2024
...it/tests/DetailsView/components/tab-stops-requirement-instances-collapsible-content.test.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7232 +/- ##
==========================================
+ Coverage 94.30% 94.32% +0.02%
==========================================
Files 1225 1224 -1
Lines 20697 20696 -1
Branches 1308 1308
==========================================
+ Hits 19518 19522 +4
+ Misses 1160 1155 -5
Partials 19 19 ☔ View full report in Codecov by Sentry. |
madalynrose
requested changes
Mar 1, 2024
Contributor
madalynrose
left a comment
There was a problem hiding this comment.
This looks awesome! There were a lot of complex tests here. I made some suggestions and once those are implemented it's ready to go!
src/tests/unit/tests/DetailsView/components/status-icon.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/status-icon.test.tsx
Outdated
Show resolved
Hide resolved
...it/tests/DetailsView/components/tab-stops-requirement-instances-collapsible-content.test.tsx
Outdated
Show resolved
Hide resolved
...it/tests/DetailsView/components/tab-stops-requirement-instances-collapsible-content.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/test-view-container.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/details-view-container.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/details-view-container.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/details-view-container.test.tsx
Outdated
Show resolved
Hide resolved
madalynrose
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Enzyme replacement in files under src/tests/unit/tests/DetailsView/
Motivation
Existing story: User Story 2142857
Replaced the use of Enzyme in the below files:
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.