chore: Enzyme replacement in test files- PR 3 of 6 for part 2 of 3 by SaanicaG · Pull Request #7210 · microsoft/accessibility-insights-web

SaanicaG · 2024-01-19T12:02:22Z

Details

Enzyme replacement done for total 20 files.

File names are mentioned below-

src/tests/unit/tests/DetailsView/components/nav-link-button.test.tsx
src/tests/unit/tests/DetailsView/components/next-requirement-button.test.tsx
src/tests/unit/tests/DetailsView/components/no-displayable-preview-features-message.test.tsx
src/tests/unit/tests/DetailsView/components/preview-features-toggle-list.test.tsx
src/tests/unit/tests/DetailsView/components/quick-assess-command-bar.test.tsx
src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx
src/tests/unit/tests/DetailsView/components/report-export-button.test.tsx
src/tests/unit/tests/DetailsView/components/report-export-component.test.tsx
src/tests/unit/tests/DetailsView/components/requirement-context-section-factory.test.tsx
src/tests/unit/tests/DetailsView/components/requirement-context-section.test.tsx
src/tests/unit/tests/DetailsView/components/requirement-instructions.test.tsx
src/tests/unit/tests/DetailsView/components/requirement-view-title-factory.test.tsx
src/tests/unit/tests/DetailsView/components/requirement-view.test.tsx
src/tests/unit/tests/DetailsView/components/restart-scan-visual-helper-toggle.test.tsx
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
src/tests/unit/tests/DetailsView/components/scan-incomplete-warning.test.tsx
src/tests/unit/tests/DetailsView/components/start-over-component-factory.test.tsx
src/tests/unit/tests/DetailsView/components/start-over-dialog.test.tsx
src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx
src/tests/unit/tests/DetailsView/components/static-content-details-view.test.tsx

Motivation

enzyme replacement in files under src/tests/unit/tests/DetailsView/components

Associated User Story - https://dev.azure.com/mseng/1ES/_workitems/edit/2136485

Context

All changes are done in test files only and snapshots are updated.

Pull request checklist

[n/a ] Addresses an existing issue: #0000
Ran yarn fastpass
Added/updated relevant unit test(s) (and ran yarn test)
Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
[ n/a ] (UI changes only) Added screenshots/GIFs to description above
[ n/a ] (UI changes only) Verified usability with NVDA/JAWS

…SaanicaG/accessibility-insights-web into v-sghate/EnzymeReplacementPart2

madalynrose

You did so much heavy lifting here! This looks awesome. I just realized we can simplify a lot of these tests so I marked places where we can use mocks instead of actual elements.

src/tests/unit/tests/DetailsView/components/restart-scan-visual-helper-toggle.test.tsx

src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx

src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx

src/tests/unit/tests/DetailsView/components/report-export-button.test.tsx

src/tests/unit/tests/DetailsView/components/start-over-dialog.test.tsx

src/tests/unit/tests/DetailsView/components/static-content-details-view.test.tsx

DaveTryon · 2024-01-29T17:42:31Z

General comment: Having a series of PR's titled "... user story ABC", "... user story DEF", "...user story GHI", etc., can be useful when tracking the implementation of the work, but once the PR is merged, its value drops dramatically, especially if the engineering system ever becomes unavailable. As an alternative, may I suggest a slightly different approach, with the intent to make it possible to understand the change even without access to the ADO system (which will be the case for any external contributor, or even internal contributors should we later change engineering systems)

The title should capture the fact that this is part of a broader set of tasks. All tasks in the set will ideally use the same pattern
The description should still point to the ADO item, but will also include the set of work included in this task. There will be some duplication with ADO--that's a good thing.

So a specific one of these tasks might have a title of "chore: Enzyme replacement in test files - part 3 of 12". The description might include something like:

Files in scope for this PR:

src/tests/unit/tests/DetailsView/components/awesome-class.test.tsx
src/tests/unit/tests/DetailsView/components/amazing-component.test.tsx
src/tests/unit/tests/DetailsView/components/incredible-navigation.test.tsx
etc.

madalynrose

A few more comments and then this looks awesome!

src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx

src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx

src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx

src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx

src/tests/unit/tests/DetailsView/components/static-content-details-view.test.tsx

madalynrose

A few more small changes!

src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx

src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx

codecov-commenter · 2024-02-06T14:33:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f54c31a) 94.31% compared to head (08d8b80) 94.31%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7210   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files        1224     1224           
  Lines       20696    20696           
  Branches     1308     1308           
=======================================
  Hits        19520    19520           
  Misses       1157     1157           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx

src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx

src/tests/unit/tests/DetailsView/components/static-content-details-view.test.tsx

…SaanicaG/accessibility-insights-web into v-sghate/EnzymeReplacementPart2

src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx

src/tests/unit/tests/DetailsView/components/report-export-component.test.tsx

src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx

src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx

SaanicaG and others added 7 commits January 12, 2024 11:58

Enzyme replacement for 3 files done

2642016

Merge branch 'microsoft:main' into v-sghate/EnzymeReplacementPart2

2c4eb0e

Enzyme replacement done for report-export-button.test.tsx

ab798bf

Merge branch 'microsoft:main' into v-sghate/EnzymeReplacementPart2

7ad3ecf

Enzyme replacement of 20 files

7ff07f5

Merge branch 'v-sghate/EnzymeReplacementPart2' of https://github.com/…

287b869

…SaanicaG/accessibility-insights-web into v-sghate/EnzymeReplacementPart2

Merge branch 'microsoft:main' into v-sghate/EnzymeReplacementPart2

074ddc8

SaanicaG changed the title ~~V sghate/enzyme replacement part2~~ chore: (enzyme replacement in test files) : User story 2136485 Jan 19, 2024

SaanicaG added 16 commits January 19, 2024 17:44

fixed format issue.

8dacbe4

Merge branch 'v-sghate/EnzymeReplacementPart2' of https://github.com/…

490643f

…SaanicaG/accessibility-insights-web into v-sghate/EnzymeReplacementPart2

Removed unnecessary declarations.

abb898a

removed unused references.

780b175

removed unnecessary references.

f098175

removed unnecessary references.

1d38fe0

Removed unnecessary references.

846aed7

fixed lint check and build issues.

6450a4c

mocked required components.

1a06eb1

removed unnecessary import

bcc4f36

mocked required components

8a24237

unmocked unnecessary components.

7a3f536

mocked necessary components.

046957d

mocked required components.

da9cb00

pushing updated snapshot

847916a

Removed unnecessary mock.

f3486ce

SaanicaG marked this pull request as ready for review January 24, 2024 14:18

SaanicaG requested a review from a team as a code owner January 24, 2024 14:18

madalynrose requested changes Jan 25, 2024

View reviewed changes

SaanicaG added 2 commits January 30, 2024 18:11

mocked required components.

38f4d8a

mocked required components

787f463

SaanicaG added 2 commits January 30, 2024 18:37

snapshot attached.

99f0627

fixed build errors

bb16e88

SaanicaG changed the title ~~chore: (enzyme replacement in test files) : User story 2136485~~ chore: Enzyme replacement in test files- PR 3 of 6 for part 2 of 3 Jan 30, 2024

madalynrose requested changes Jan 31, 2024

View reviewed changes

SaanicaG added 4 commits February 2, 2024 13:13

mocked necessary components as per PR comments.

ad08ddf

Fixed build issue.

c76f186

mocked required components

765cf1d

mocked required component as per PR suggestion.

823baf5

madalynrose requested changes Feb 5, 2024

View reviewed changes

SaanicaG added 2 commits February 6, 2024 19:40

Done changes as per PR comments for the file.

8c7bed4

Fixed format check issues.

90fa762

SaanicaG and others added 4 commits February 6, 2024 20:11

Done changes according to PR comment.

6fb43be

Resolved build error.

8784e18

fixed format issues.

8ad7cfb

Merge branch 'microsoft:main' into v-sghate/EnzymeReplacementPart2

977f9f7

madalynrose requested changes Feb 6, 2024

View reviewed changes

SaanicaG added 2 commits February 7, 2024 10:50

Done changes as per PR comments.

41461c7

Merge branch 'v-sghate/EnzymeReplacementPart2' of https://github.com/…

5213194

…SaanicaG/accessibility-insights-web into v-sghate/EnzymeReplacementPart2

v-rakeshsh reviewed Feb 7, 2024

View reviewed changes

src/tests/unit/tests/DetailsView/components/quick-assess-to-assessment-dialog.test.tsx Outdated Show resolved Hide resolved

v-rakeshsh reviewed Feb 7, 2024

View reviewed changes

src/tests/unit/tests/DetailsView/components/report-export-component.test.tsx Outdated Show resolved Hide resolved

v-rakeshsh reviewed Feb 7, 2024

View reviewed changes

src/tests/unit/tests/DetailsView/components/report-export-component.test.tsx Outdated Show resolved Hide resolved

Implemented changes as per PR comments.

b94329f

madalynrose requested changes Feb 8, 2024

View reviewed changes

SaanicaG added 3 commits February 9, 2024 16:14

Done changes as per PR comments.

81aa52c

code fixes.

0db3773

done format fix

08d8b80

madalynrose approved these changes Feb 13, 2024

View reviewed changes

v-viyada merged commit 457a477 into microsoft:main Feb 13, 2024

Conversation

SaanicaG commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Motivation

Context

Pull request checklist

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaveTryon commented Jan 29, 2024

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madalynrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SaanicaG commented Jan 19, 2024 •

edited

Loading

codecov-commenter commented Feb 6, 2024 •

edited

Loading