Skip to content

chore: Enzyme replacement in test files- PR 1 of 6 for part 2 of 3#7207

Merged
v-singhanjal merged 15 commits intomicrosoft:mainfrom
v-singhanjal:enzyme_replacement
Jan 30, 2024
Merged

chore: Enzyme replacement in test files- PR 1 of 6 for part 2 of 3#7207
v-singhanjal merged 15 commits intomicrosoft:mainfrom
v-singhanjal:enzyme_replacement

Conversation

@v-singhanjal
Copy link
Copy Markdown
Contributor

@v-singhanjal v-singhanjal commented Jan 18, 2024 •
edited
Loading

Details

Enzyme replacement in files under src/tests/unit/tests/DetailsView/components

Motivation

Existing story: User Story 2136480

Replaced the use of Enzyme in the below files:

  1. react-extension-point.test.tsx
  2. named-fc.test.tsx
  3. index.test.tsx
  4. current-view.test.tsx
  5. telemetry-common-fields.test.tsx
  6. telemetry-messages-list.test.tsx
  7. telemetry-viewer.test.tsx
  8. debug-tools-nav.test.tsx
  9. debug-tools-view.test.tsx
  10. stores-tree.test.tsx
  11. preview-features-container.test.tsx
  12. scoping-container.test.tsx
  13. auto-detected-failures-dialog-settings.test.tsx
  14. high-contrast/high-contrast-settings.test.tsx
  15. issue-filing-settings.test.tsx
  16. save-assessment-dialog.test.tsx
  17. telemetry-settings.test.tsx
  18. settings-panel.test.tsx
  19. assessment-left-nav.test.tsx
  20. details-view-left-nav.test.tsx

Code coverage before and after codeshift checked and it is same.

Context

Pull request checklist

  • Addresses an existing issue: 2136480
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a ] (UI changes only) Verified usability with NVDA/JAWS

@v-singhanjal v-singhanjal changed the title Made changes in files for enzyme replacement. chore: Enzyme replacement in test files (User Story 2136480) Jan 23, 2024
@v-singhanjal v-singhanjal marked this pull request as ready for review January 24, 2024 09:37
@v-singhanjal v-singhanjal requested a review from a team as a code owner January 24, 2024 09:37
@v-singhanjal v-singhanjal marked this pull request as draft January 24, 2024 09:38
@v-singhanjal v-singhanjal marked this pull request as ready for review January 24, 2024 09:48
madalynrose
madalynrose requested changes Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits and then this looks good to go!

@DaveTryon
Copy link
Copy Markdown
Contributor

DaveTryon commented Jan 29, 2024

General comment: Having a series of PR's titled "... user story ABC", "... user story DEF", "...user story GHI", etc., can be useful when tracking the implementation of the work, but once the PR is merged, its value drops dramatically, especially if the engineering system ever becomes unavailable. As an alternative, may I suggest a slightly different approach, with the intent to make it possible to understand the change even without access to the ADO system (which will be the case for any external contributor, or even internal contributors should we later change engineering systems)

  • The title should capture the fact that this is part of a broader set of tasks. All tasks in the set will ideally use the same pattern
  • The description should still point to the ADO item, but will also include the set of work included in this task. There will be some duplication with ADO--that's a good thing.

So a specific one of these tasks might have a title of "chore: Enzyme replacement in test files - part 3 of 12". The description might include something like:

Files in scope for this PR:

  • src/tests/unit/tests/DetailsView/components/awesome-class.test.tsx
  • src/tests/unit/tests/DetailsView/components/amazing-component.test.tsx
  • src/tests/unit/tests/DetailsView/components/incredible-navigation.test.tsx
    etc.

@v-singhanjal v-singhanjal changed the title chore: Enzyme replacement in test files (User Story 2136480) chore: Enzyme replacement in test files- PR 1 of 6 for part 2 of 3 Jan 30, 2024
@v-singhanjal v-singhanjal merged commit d6daece into microsoft:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madalynrose madalynrose madalynrose approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-singhanjal @DaveTryon @madalynrose