feat(medium-pass-1): register MediumPass callbacks in ActionCreator#6227
Merged
waabid merged 5 commits intomicrosoft:mainfrom Dec 2, 2022
Merged
Conversation
Contributor
|
This looks great! One question: why don't we need separate callbacks for |
Member
I believe it's due to telemetry event names being specific for Assessment or not. If they are not specific, we can use the same functions. The visualization type will be different though, so we'll still be able to differentiate FWIW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR ensures that the MediumPass/QuickAssess equivalents of Assessment callbacks are registered in ActionCreator
Motivation
Part of feature work
Context
Pull request checklist
yarn null:autoaddyarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.