Skip to content

chore: rephrase parsing instructions in assessments#6154

Merged
ferBonnin merged 1 commit intomicrosoft:mainfrom
Pranav-yadav:chore/parsing-instructions
Oct 27, 2022
Merged

chore: rephrase parsing instructions in assessments#6154
ferBonnin merged 1 commit intomicrosoft:mainfrom
Pranav-yadav:chore/parsing-instructions

Conversation

@Pranav-yadav
Copy link
Copy Markdown
Contributor

@Pranav-yadav Pranav-yadav commented Oct 27, 2022 •
edited
Loading

Details

chore: rephrase parsing instructions in assessments

as suggested under #6130 (comment)

Suggestion: maybe "Go to the browser tab containing your target page and, in that browser window, select the first bookmarklet"?

Motivation

closes #6130

Context

Instructions shown to user during Parsing Assessments

currently;

accessibility-insights-web/src/assessments/parsing/test-steps/parsing.tsx

Lines 52 to 56 in 7ef8ee7

Run the first bookmarklet in the browser tab containing your target page. It will
send the page's DOM to the checker and show the results in a new browser tab.
</li>
<li>
Run the second bookmarklet in the browser tab containing the checker results. It

Pull request checklist

  • Addresses an existing issue: Parsing instructions can be confusing #6130
  • [-] Ran yarn null:autoadd
  • [-] Ran yarn fastpass
  • [-] Added/updated relevant unit test(s) (and ran yarn test)
  • [-] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [-] (UI changes only) Added screenshots/GIFs to description above
  • [-] (UI changes only) Verified usability with NVDA/JAWS

@Pranav-yadav Pranav-yadav requested a review from a team as a code owner October 27, 2022 16:15
@Pranav-yadav Pranav-yadav force-pushed the chore/parsing-instructions branch from 79ec812 to 923c18e Compare October 27, 2022 16:27
@Pranav-yadav
Copy link
Copy Markdown
Contributor Author

Pranav-yadav commented Oct 27, 2022

@ferBonnin done the required changes! do review and merge :)

PS: reminder: add hacktoberfest-accepted label before merging 👍

@ferBonnin ferBonnin requested a review from waabid October 27, 2022 18:16
waabid
waabid approved these changes Oct 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@ferBonnin ferBonnin merged commit 997a3d5 into microsoft:main Oct 27, 2022
@Pranav-yadav Pranav-yadav deleted the chore/parsing-instructions branch October 28, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@waabid waabid waabid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parsing instructions can be confusing

3 participants

@Pranav-yadav @waabid @ferBonnin