fix: prevent toast message visibility when pressing copy failure details button from an insecure target page#4234
Merged
jalkire merged 14 commits intomicrosoft:mainfrom May 19, 2021
Conversation
update copy issue details toast message display help text to direct users to details page
…ights-web into copy-failure-details-fix
…ights-web into copy-failure-details-fix
…ights-web into copy-failure-details-fix
…ights-web into copy-failure-details-fix
…ights-web into copy-failure-details-fix
…secure target page
…ights-web into copy-failure-details-fix
Contributor
|
Thank you for another contribution! We will get it reviewed shortly 🙂 |
jalkire
approved these changes
May 19, 2021
Contributor
jalkire
left a comment
There was a problem hiding this comment.
This looks like an improvement to me! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR is a continuation of PR #4170 and addresses the bug described in #4211.
Previously, from an insecure target page, if a user clicks the "Copy failure details" button then two messages will render:
Now, this PR removes the aforementioned toast pop-up. Example screenshot is shown below.
Motivation
Addresses bug #4211
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.