Skip to content

fix: remove wcag link and replace it with best practice in headings assessment guidance#2480

Merged
dbjorge merged 2 commits intomicrosoft:masterfrom
Shobhit1:fix-heading-guidance
Apr 14, 2020
Merged

fix: remove wcag link and replace it with best practice in headings assessment guidance#2480
dbjorge merged 2 commits intomicrosoft:masterfrom
Shobhit1:fix-heading-guidance

Conversation

@Shobhit1
Copy link
Copy Markdown
Contributor

Description of changes

Remove the WCAG 1.3.1 link from headings guidance.

Pull request checklist

  • Addresses an existing issue: Guidance in Headings for top-level should be best practice  #2444
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

Screenshot

Screen Shot 2020-04-12 at 3 17 05 PM

@Shobhit1 Shobhit1 requested a review from a team as a code owner April 12, 2020 22:21
@msftclas
Copy link
Copy Markdown

msftclas commented Apr 13, 2020

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dbjorge dbjorge merged commit 10096c7 into microsoft:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants