fix: minor changes to improve stability for e2e tests#1722
Merged
dbjorge merged 2 commits intomicrosoft:masterfrom Nov 21, 2019
Merged
fix: minor changes to improve stability for e2e tests#1722dbjorge merged 2 commits intomicrosoft:masterfrom
dbjorge merged 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Hello @Shobhit1! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dbjorge
approved these changes
Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
One of the most common timeout issue in our e2e was in settings-panel & high-contrast e2e tests where the
keyPress('escape')was not getting registered properly and so I changed that event with pressing the cross button on the settings panel to exit it. This should hopefully fix that timeout error on settings panel tests.Also added
--no-cachetoyarn:devin our docker to avoid a dev build cache system which I was hitting regularly in my local build.Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). Check workflow guide at:<rootDir>/docs/workflow.md