This repository was archived by the owner on May 28, 2025. It is now read-only.
Support for Pattern transformation.#2263
Merged
msft-Jeyaram merged 6 commits intoMar 23, 2017
Merged
Conversation
msft-Jeyaram
commented
Mar 17, 2017
|
|
||
| // Draw it in device space, so transformation is not applied to the render target. | ||
| coordinateMode = _kCGCoordinateModeDeviceSpace; | ||
| geometry.Attach(transformedGeometry.Detach()); |
Author
There was a problem hiding this comment.
note: As per D2D DrawGeo.. a transformed geometry will have a thinner line width, than an untransformed geometry + transformation.
Working on a fix in the coming iteration. #Resolved
|
Do we have any tests for stroking with a pattern brush? #Resolved |
Author
|
@DHowett-MSFT TEST_P(CGPatternColoredRectBasedStroke, PatternStrokeRegion) { |
DHowett-MSFT
previously requested changes
Mar 17, 2017
| CGContextFillRect(context, bounds); | ||
| } | ||
|
|
||
| DRAW_TEST_F(CGPatternTests, PatternFillTransformationWindowsLogoTranslate, UIKitMimicTest<>) { |
There was a problem hiding this comment.
these can be parameterized on CGAffineTransform #ByDesign
There was a problem hiding this comment.
also, we don't know what happens to stroke pattern brushes under transformation #Resolved
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I cannot review this in time for my vacation, but I am not going to leave it with an ❌
I recuse myself from review.
bab9b92 to
859f25f
Compare
rajsesh
reviewed
Mar 23, 2017
| ComPtr<ID2D1Factory> factory; | ||
| deviceContext->GetFactory(&factory); | ||
|
|
||
| ComPtr<ID2D1Factory1> factory1; |
Contributor
There was a problem hiding this comment.
factory1 [](start = 30, length = 8)
factory.As(&factory1)? also no need for fail fasts here, we will crash right afterwards anyway. #Resolved
rajsesh
approved these changes
Mar 23, 2017
added 5 commits
March 22, 2017 21:12
…ion, scaling or translation. Thus any transformation that is done to the context, should only be applied to the context and not the CGPattern image. CGPattern image, which is drawn via the callback should be treated like an image. Adding image scaling and proper sizing to the user drawn CGPattern image.
…to the render target. Thus this way, any transformation to the context is applied to the geometry before being drawn (vs. applying the geometry to the render target the drawing). This will allow sub-mechanism (e.g brushes) to keep their proper orientation while being drawn. This is funneled through Draw() function, thus since the geometry is already transformed, the coordinate mode is set to _kCGCoordinateModeDeviceSpace to ensure that transform is not applied to the render target.
The line width should not subject to transformation (but should respect DPI). Fixing the Stroke so that it does not apply the transformation to the stroke, but respect the DPI values (e.g thicker/thinner).
Also including CoreGraphics vs UIKit based tests.
d81e803 to
bce05fa
Compare
- GetBoundingBox - PathApplyControlPointsQuadCurve - PathApplyControlPointsArcs - PathApplyControlPointsArcsSimple These tests had the wrong reference image, also these are UIKit based tests. Currently, UIKit mimicking of 2x scaling for strokes is not implemented.
bce05fa to
21fc872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2108