Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Allow return of non-GDI-compatible family/subfamily names from CTFont…#1778

Merged
ms-jihua merged 1 commit into
microsoft:developfrom
ms-jihua:fontfamily
Jan 24, 2017
Merged

Allow return of non-GDI-compatible family/subfamily names from CTFont…#1778
ms-jihua merged 1 commit into
microsoft:developfrom
ms-jihua:fontfamily

Conversation

@ms-jihua

@ms-jihua ms-jihua commented Jan 24, 2017

Copy link
Copy Markdown
Contributor

…Copy(Family)Name et al

Fixes #1758


This change is Reviewable

@msft-Jeyaram

Copy link
Copy Markdown

This was the root cause of #1751
Please close that with this.

@ms-jihua

Copy link
Copy Markdown
Contributor Author

@msft-Jeyaram I'm confused what issue #1751 is actually describing - if it's describing an issue in NSLayoutManager with:
CTLineRef fitLine = static_cast(CFArrayGetValueAtIndex(CTFrameGetLines(frame.get()), 0));
then that issue still repros, and this was not the root cause (I may have also just opened a dupe at #1779)

@msft-Jeyaram

Copy link
Copy Markdown

@ms-jihua I updated the bug #1751 .
This might not as well be related, but I have seen the crash upon attempting to obtain
static_cast(CFArrayGetValueAtIndex(CTFrameGetLines(frame.get()), 0)); and the frame is empty.

Are you able to repo as per #1751 steps?

@ms-jihua

Copy link
Copy Markdown
Contributor Author

@msft-Jeyaram I am not able to repro the #1751 stack. I get #1758 on develop and #1779 after this change.

@ms-jihua ms-jihua merged commit 955b1c8 into microsoft:develop Jan 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants