This repository was archived by the owner on May 28, 2025. It is now read-only.
[ut] Pull common logic out into a common makefile.#1352
Merged
DHowett-MSFT merged 2 commits intoNov 10, 2016
Conversation
aballway
approved these changes
Nov 10, 2016
| SRCFILES := $(wildcard $(SRCDIR)/*.m*) | ||
| RF_SRCFILES := $(wildcard $(SRCDIR)/ReferenceFoundation/*.mm) | ||
| # ... and in ReferenceFoundation. | ||
| UT_FILES += $(wildcard ReferenceFoundation/*.mm) |
Contributor
There was a problem hiding this comment.
nit: .m here? --Scratch that, maybe a comment saying all are .mm in RF
ms-jihua
reviewed
Nov 10, 2016
| CFLAGS += -mmacosx-version-min=$(OSX_VERSION_MIN) | ||
| CFLAGS += $(UT_CFLAGS) | ||
|
|
||
| _UT_FRAMEWORKS := CoreFoundation Foundation $(UT_FRAMEWORKS) |
Contributor
There was a problem hiding this comment.
$(UT_FRAMEWORKS) [](start = 44, length = 16)
this doesn't seem to be declared anywhere, is the expectation that we'll have dirty flags when making this makefile?
Author
There was a problem hiding this comment.
Some of these can be empry; UT_FRAMEWORKS is one of them.
If RESOURCES, RESOURCE_DIRS, FRAMEWORKS, CFLAGS, or LDFLAGS are empty, they're ignored.
Contributor
|
|
Author
|
Bypassing CI builds as this change does not touch built collateral. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the develop side of the Makefile changes from #1348!
Normal use is documented in Foundation/Makefile.
The aggregate makefile has been updated to truly support multiple tests.
This change is