Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Making callbacks agile. Fixing seek in ebrstroragefile.#1344

Merged
pradipd merged 1 commit into
microsoft:developfrom
pradipd:develop
Nov 10, 2016
Merged

Making callbacks agile. Fixing seek in ebrstroragefile.#1344
pradipd merged 1 commit into
microsoft:developfrom
pradipd:develop

Conversation

@pradipd

@pradipd pradipd commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

This change is Reviewable

@pradipd

pradipd commented Nov 9, 2016

Copy link
Copy Markdown
Contributor Author

@bbowman is added to the review. #Closed


#pragma region Async Helpers
struct ActionCallback : public Microsoft::WRL::RuntimeClass<Microsoft::WRL::RuntimeClassFlags<Microsoft::WRL::ClassicCom>,
struct ActionCallback : public Microsoft::WRL::RuntimeClass<Microsoft::WRL::RuntimeClassFlags<Microsoft::WRL::WinRtClassicComMix>,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WinRtClassicComMix [](start = 110, length = 18)

Doh!!! I tihnk we've gone through this exercise before. My bad.

@pradipd pradipd Nov 10, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Thanks for the review.


In reply to: 87461400 [](ancestors = 87461400)

@bbowman

bbowman commented Nov 10, 2016

Copy link
Copy Markdown
Member

:shipit:

1 similar comment
@DHowett-MSFT

Copy link
Copy Markdown

:shipit:

@pradipd pradipd merged commit 22fcc07 into microsoft:develop Nov 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants