This repository was archived by the owner on May 28, 2025. It is now read-only.
Support multiple line break modes#1319
Merged
Merged
Conversation
rajsesh
suggested changes
Nov 4, 2016
| // TODO 1121:: DWrite does not support line breaking by truncation, so just use default for now | ||
| case kCTLineBreakByTruncatingHead: | ||
| case kCTLineBreakByTruncatingTail: | ||
| case kCTLineBreakByTruncatingMiddle: |
Contributor
There was a problem hiding this comment.
Thats not a reasonable default for truncation. LineBreakByClipping is more palatable instead.
Contributor
|
|
rajsesh
approved these changes
Nov 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now support kCTLineBreakByWordWrapping, kCTLineBreakByCharWrapping, and kCTLineBreakByClipping. Also adds a helper file for unit tests to use default testing macros with CG/CF structs.
This change is