Composition and layout refactor by jaredhms · Pull Request #1318 · microsoft/WinObjC

jaredhms · 2016-11-04T19:27:49Z

This change refactors WinObjC's QuartzCore and UIKit stacks to align more closely with Xaml, as detailed in the docs/CoreAnimation/WinObjc.Composition.and.Layout.docx dev spec.

Some highlights include:

1.	Streamlines the usage of arbitrary Xaml FrameworkElements by allowing them to be positioned just as any other UIView in the application.
2.	Supports rendering over Xaml-backed UIKit controls; adding adornments, etc.
3.	Supports adding subviews and sublayers to Xaml-backed UIKit controls.
4.	Separates the complex details of our Core Animation composition layer into distinct and manageable subcomponents � improving maintainability.
5.	Defines a concrete relationship between every UIView, its root CALayer, and its backing Xaml FrameworkElement.
6.	Streamlines the UIElement tree by removing unnecessary UIElements (for example; this results in a ~30% reduction of UIElements on the initial scene of WOCCatalog).
7.	Simplifies app rendering by removing our two custom Panel implementations; thus eliminating the need to take part in Arrange and Measure passes.
8.	Paves the way for eventual Xaml-markup-driven UIElement trees in ported WinObjC apps, because we no longer require re-parenting Xaml FrameworkElements that are positioned by Core Animation.
9.	Moves the rest of the Core Animation composition layer over to C++, to benefit from modern programming constructs such as RAII, external ref-counting (shared_ptr), etc.

In order to implement these changes, we had to move UILabel over to a fully Xaml-backed implementation (rather than following a more complicated path with fake 'textures' down into the compositor). As a result, there are some known issues around text layout in one of our internal test apps (MM); we'll address those issues (and anything else that comes up) in a stabilization pass after these changes go in.

This change is

…more closely with Xaml, as detailed in the docs/CoreAnimation/WinObjc.Composition.and.Layout.docx dev spec. Some highlights include: 1. Streamlines the usage of arbitrary Xaml FrameworkElements by allowing them to be positioned just as any other UIView in the application. 2. Supports rendering over Xaml-backed UIKit controls; adding adornments, etc. 3. Supports adding subviews and sublayers to Xaml-backed UIKit controls. 4. Separates the complex details of our Core Animation composition layer into distinct and manageable subcomponents � improving maintainability. 5. Defines a concrete relationship between every UIView, its root CALayer, and its backing Xaml FrameworkElement. 6. Streamlines the UIElement tree by removing unnecessary UIElements (for example; this results in a ~30% reduction of UIElements on the initial scene of WOCCatalog). 7. Simplifies app rendering by removing our two custom Panel implementations; thus eliminating the need to take part in Arrange and Measure passes. 8. Paves the way for eventual Xaml-markup-driven UIElement trees in ported WinObjC apps, because we no longer require re-parenting Xaml FrameworkElements that are positioned by Core Animation. 9. Moves the rest of the Core Animation composition layer over to C++, to benefit from modern programming constructs such as RAII, external ref-counting (shared_ptr), etc. In order to implement these changes, we had to move UILabel over to a fully Xaml-backed implementation (rather than following a more complicated path with fake 'textures' down into the compositor). As a result, there are some known issues around text layout in one of our internal test apps (MM); we'll address those issues (and anything else that comes up) in a stabilization pass after these changes go in.

jaredhms · 2016-11-04T19:29:16Z

@msft-Jeyaram is added to the review. #Closed

jaredhms · 2016-11-04T19:29:17Z

@ashvarma is added to the review. #Closed

jaredhms · 2016-11-04T19:29:17Z

@bviglietta is added to the review. #Closed

bbowman · 2016-11-04T19:34:58Z

//

doesn't seem changed? #Resolved

Refers to: Frameworks/include/MockClass.h:4 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-04T19:35:44Z

//

just some clang-format whitespace changes....

In reply to: 258527516 [](ancestors = 258527516)

Refers to: Frameworks/include/MockClass.h:4 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-04T19:37:14Z

+#import "CAAnimationInternal.h"
+#import "CALayerInternal.h"
+
+static const wchar_t* TAG = L"LayerTransaction";


LayerTransaction [](start = 30, length = 16)

A lot of this came from CompositorInterface.mm. #Resolved

jaredhms · 2016-11-04T19:37:24Z

+
+void LayerProxy::SetTexture(const std::shared_ptr<IDisplayTexture>& texture, float width, float height, float contentScale) {
+    _currentTexture = texture;
+    _SetContents((texture ? texture->GetContent() : nullptr), width, height, contentScale);


A lot of this came from CompositorInterface.mm. #Resolved

jaredhms · 2016-11-04T19:37:45Z

+
+        _type = [type retain];
+        _subType = [subType retain];
+        beginTime = 0;


A lot of this came from CompositorInterface.mm; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:37:52Z

+
+using namespace Microsoft::WRL;
+
+static const wchar_t* TAG = L"DisplayTexture";


DisplayTexture [](start = 30, length = 14)

A lot of this came from CompositorInterface.mm; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:38:01Z

+
+#import <algorithm>
+
+static const wchar_t* TAG = L"DisplayProperties";


DisplayProperties [](start = 30, length = 17)

A lot of this came from CompositorInterface.mm; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:38:30Z

@@ -381,7 +381,9 @@ UIKIT_EXPORT_CLASS
 // WinObjC Xaml Extensions


Dustin; I don't think we currently have an annotation for this. #Resolved

jaredhms · 2016-11-04T19:39:09Z

 @class WXFrameworkElement;
 @interface UIView (UIKitXamlExtensions)
-@property (nonatomic, retain) WXFrameworkElement* xamlElement;
+ (WXFrameworkElement*)createXamlElement;


Couldn't go with the 'layerClass' model here, because the types we want to create are in UIKit.Xaml and are not yet projected to ObjC. #Resolved

jaredhms · 2016-11-04T19:39:50Z

+using namespace Windows::UI::Xaml::Controls;
+using namespace Windows::UI::Xaml::Media;
+
+static const wchar_t* TAG = L"DisplayTexture";


DisplayTexture [](start = 30, length = 14)

A lot of this came from either CALayerXaml.cpp or XamlCompositor.cpp; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:39:57Z

+using namespace Windows::UI::Xaml::Media;
+using namespace Windows::UI::Xaml::Media::Imaging;
+
+static const wchar_t* TAG = L"LayerAnimation";


LayerAnimation [](start = 30, length = 14)

A lot of this came from either CALayerXaml.cpp or XamlCompositor.cpp; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:40:05Z

+using namespace Windows::UI::Xaml::Media::Animation;
+using namespace Windows::UI::Xaml::Media::Imaging;
+
+static const wchar_t* TAG = L"LayerCoordinator";


LayerCoordinator [](start = 30, length = 16)

A lot of this came from either CALayerXaml.cpp or XamlCompositor.cpp; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:40:11Z

+using namespace Windows::UI::Xaml::Controls;
+using namespace Windows::UI::Xaml::Media;
+
+static const wchar_t* TAG = L"LayerProxy";


LayerProxy [](start = 30, length = 10)

A lot of this came from either CALayerXaml.cpp or XamlCompositor.cpp; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:40:18Z

+using namespace Windows::UI::Xaml::Media::Animation;
+using namespace Windows::UI::Xaml::Media::Imaging;
+
+static const wchar_t* TAG = L"StoryboardManager";


StoryboardManager [](start = 30, length = 17)

A lot of this came from either CALayerXaml.cpp or XamlCompositor.cpp; sorry it's not easy to diff. #Resolved

jaredhms · 2016-11-04T19:40:45Z

+
+using namespace Microsoft::WRL;
+
+static const wchar_t* TAG = L"XamlCompositor";


XamlCompositor [](start = 30, length = 14)

This is the remains of CompositorInterface.mm. #Resolved

DHowett-MSFT · 2016-11-04T19:50:53Z


+/**
+ Microsoft Extension
+ All CALayers are ultimately backed by a Xaml FrameworkElement.  Passing nil here will


We should push for a @status to note this, it'd be cool to show our additions in another chart area #Resolved

that's a good idea; i'll follow up on it.

In reply to: 86620194 [](ancestors = 86620194)

DHowett-MSFT · 2016-11-04T19:52:35Z

+ @Status Interoperable
+*/
+- (CGAffineTransform)affineTransform {
+    CGAffineTransform ret;


eTransform re [](start = 11, length = 13)

Instead of poking at these directly, you can use CGAffineTransformMake(a,b,c,d,tx,ty) #Resolved

aballway · 2016-11-04T19:53:21Z

+    // Query for our backing XAML node.
+    // ILayerProxy will have created one if the xamlElement passed into the previous CreateLayerProxy call was nullptr.
+    Microsoft::WRL::ComPtr<IInspectable> inspectable(_layerProxy->GetXamlElement());
+    _xamlElement = _createRtProxy([WXFrameworkElement class], inspectable.Get());


use createwith here? #Resolved

aballway · 2016-11-04T19:57:16Z

-                                before ? [before _priv]->_presentationNode : NULL,
-                                after ? [after _priv]->_presentationNode : NULL);
+    [self _currentLayerTransaction]->MoveLayer([layer _layerProxy],
+                                               before ? [before _layerProxy] : nullptr,


nit: shouldn't need to make ternary with messages here #ByDesign

yeah: if before is nil, [nil _layerProxy] will return the right thing. Unless it's a C++ type, but really the ideal here is to do the right thing :P

In reply to: 86621323 [](ancestors = 86621323)

the compiler on the reference platform memsets an out struct pointer to 0 if the destination of the message is nil.

In reply to: 86900544 [](ancestors = 86900544,86621323)

_layerProxy returns an std::shared_ptr; not doing the nil check lead to AVs.

In reply to: 86900578 [](ancestors = 86900578,86900544,86621323)

oliversa-msft · 2016-11-07T23:38:01Z

            ret = [CATransaction _implicitAnimationForKey:key];
            if (ret != nil) {
-                NSObject* value = GetCACompositor()->getDisplayProperty(priv->_presentationNode, [key UTF8String]);
+                NSObject* value = reinterpret_cast<NSObject*>(priv->_layerProxy->GetPropertyValue([key UTF8String]));


priv->_layerProxy->GetPropertyValue [](start = 62, length = 35)

Sweet! #Resolved

jaredhms · 2016-11-07T23:48:46Z

what code change are you referring to? I just deleted a bunch of dead code around setting the 'shouldAnimate' flag.

In reply to: 258998954 [](ancestors = 258998954)

Refers to: Frameworks/QuartzCore/CALayer.mm:1803 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

oliversa-msft · 2016-11-08T00:03:43Z


+    // Get the backing sublayer xaml UIElement for fromLayer
+    // We use the sublayer element to support proper point conversion within a scrolled view.
+    WXUIElement* fromLayerElement = [fromLayer _getSublayerXamlElement];


WXUIElement* [](start = 4, length = 12)

Could we make this work with WXFrameworkElement instead? Just wondering if we need to keep it consistent for readability or is there something else that is used in the parent class. #Resolved

transformToVisual is on UIElement.

In reply to: 86898072 [](ancestors = 86898072)

yiyang-msft · 2016-11-08T00:07:57Z

oliversa-msft · 2016-11-08T00:15:53Z

__declspec(thread) CATransaction* _curTransaction, *_rootTransaction;

Really should be prefixed with g_ #Resolved

Refers to: Frameworks/QuartzCore/CATransaction.mm:35 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

DHowett-MSFT · 2016-11-08T00:25:42Z

@@ -36,14 +36,15 @@



Nits about these guys:

__declspec(thread) objective-C things will not be properly ref-counted.

they're being compared against NULL (not even nullptr!) instead of nil everywhere in this file.
#Resolved

I don't want to change this now, but I'll add a TODO in the code.

In reply to: 86900474 [](ancestors = 86900474)

jaredhms · 2016-11-08T00:40:24Z

~bad merge; good catch

In reply to: 258638949 [](ancestors = 258638949)

Refers to: Frameworks/UIKit.Xaml/ObjCXamlControls.h:75 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:42:51Z

#define CACompositorRotation90CounterClockwise 270.0f

good point - these should have moved along with the rest of the DisplayProperties -- into DisplayProperties.h -- and switched to an enum.

In reply to: 258740082 [](ancestors = 258740082)

Refers to: Frameworks/include/CACompositor.h:117 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:43:45Z

CGColorRef _backgroundColor, _borderColor;

there's no reason. they should all be underscored, but i'm not going to do that in this change - I don't want to unnecessarily add to the churn.

In reply to: 258966276 [](ancestors = 258966276)

Refers to: Frameworks/include/CALayerInternal.h:65 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:44:50Z

CGColorRef _backgroundColor, _borderColor;

ideally they would all be private, too....so it's easier to see which state is accessed externally, but I'm not fixing that now, either.

In reply to: 259010707 [](ancestors = 259010707,258966276)

Refers to: Frameworks/include/CALayerInternal.h:65 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:45:20Z

(void)exchangeSublayer:(CALayer_)layer1 withLayer:(CALayer_)layer2;

there are a lot of missing underscores, but I'm not going to address them with this change.

In reply to: 258967895 [](ancestors = 258967895)

Refers to: Frameworks/include/CALayerInternal.h:111 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:45:36Z

(void)exchangeSubviewAtIndex:(int)index1 withSubviewAtIndex:(int)index2;

I'm not going to remove any more code with this change.

In reply to: 258968776 [](ancestors = 258968776)

Refers to: Frameworks/include/CALayerInternal.h:112 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:45:58Z

(void)bringSublayerToFront:(CALayer*)sublayer;

see above; i'm not going to fix the missing underscore issue with this change.

In reply to: 258968087 [](ancestors = 258968087)

Refers to: Frameworks/include/CALayerInternal.h:114 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

jaredhms · 2016-11-08T00:47:02Z

CACompositorInterface* _globalCompositor;

could have, but didn't bother making that change with this refactor. it may open up additional cans of worms, and isn't necessary at this time.

In reply to: 258982393 [](ancestors = 258982393)

Refers to: Frameworks/QuartzCore/CALayer.mm:101 in ff95a9a. [](commit_id = ff95a9a, deletion_comment = False)

…stant usage.

oliversa-msft · 2016-11-09T21:24:30Z

+ Microsoft Extension
+*/
+ (WXFrameworkElement*)createXamlElement {
+    // Default to CALayer's default backing Xaml element


// Default to CALayer's default backing Xaml element [](start = 4, length = 52)

Stale comment? #Resolved

nope, but i'll change it to '// Use CALayer's default backing Xaml element' since i was overusing 'default' :)

In reply to: 87280021 [](ancestors = 87280021)

oliversa-msft · 2016-11-09T21:27:52Z

return self;

Shouldn't this one be the designated initializer and call [super init] as well? You can then pipe initWithIdentifier through it for a simple optimization of the autoResizingMask setting. #Pending

Refers to: Frameworks/UIKit/UIViewController.mm:248 in 6d10e3d. [](commit_id = 6d10e3d, deletion_comment = False)

jaredhms · 2016-11-09T21:30:39Z

return self;

maybe? I didn't add/change this code though.

In reply to: 259531590 [](ancestors = 259531590)

Refers to: Frameworks/UIKit/UIViewController.mm:248 in 6d10e3d. [](commit_id = 6d10e3d, deletion_comment = False)

oliversa-msft · 2016-11-09T21:31:34Z

    [_pageMappings setObject:self forKey:(id)(void*)pageObj.Get()];

+    // Create a template UIView
+    priv->_page = CreateRtProxy([WXCPage class], pageObj.Get());


CreateRtProxy [](start = 18, length = 13)

This utility function doesn't have the autorelease support. Is that intentional? #Pending

we should file a bug to get rid of CreateRtProxy. I'll move this one to createWith.

In reply to: 87281267 [](ancestors = 87281267)

also - why doesn't CreateRtProxy autorelease? Quite strange.

In reply to: 87281492 [](ancestors = 87281492,87281267)

oliversa-msft · 2016-11-09T21:35:35Z

+- (instancetype)initWithFrame:(CGRect)frame {
    // Run on the main thread because the underlying XAML objects can only be
    // called from the UI thread
    RunSynchronouslyOnMainThread(^{


RunSynchronouslyOnMainThread [](start = 4, length = 28)

Should we have called [super init] preceded this as well? UIView -> UIResponder -> NSObject? I noticed that UIWebView has this pattern. #Pending

Maybe? Although, UIView's init calls initWithFrame, which is the designated initializer for UIView. Regardless, I'd prefer to get this in before we make any more changes to UIView's init path (assuming this is functionally correct and isn't introducing any regressions).

In reply to: 87282018 [](ancestors = 87282018)

oliversa-msft · 2016-11-09T21:53:13Z

+
+Label::Label() {
+    InitializeComponent();
+    Name = L"UILabel";


Name = L"UILabel"; [](start = 4, length = 18)

I wonder if we did this in the other controls as well. Seems like a good idea. #Resolved

I'll move it up to UILabel.mm so we can set the name of the actual (potentially derived) class.

In reply to: 87285187 [](ancestors = 87285187)

actually, it's already handled in UIView.mm, so I'll delete it from here and also from UIButton.mm.

In reply to: 87285928 [](ancestors = 87285928,87285187)

oliversa-msft · 2016-11-09T22:01:39Z

jaredhms assigned davelamb, DHowett-MSFT, rajsesh, bbowman, yiyang-msft, oliversa-msft and tadam-msft Nov 4, 2016

msftclas added the cla-not-required label Nov 4, 2016

jaredhms commented Nov 4, 2016

View reviewed changes

DHowett-MSFT reviewed Nov 4, 2016

View reviewed changes

aballway approved these changes Nov 4, 2016

View reviewed changes

oliversa-msft reviewed Nov 7, 2016

View reviewed changes

oliversa-msft reviewed Nov 8, 2016

View reviewed changes

Fixing text rendering issue in MM.

e96c315

DHowett-MSFT reviewed Nov 8, 2016

View reviewed changes

Addressing CR feedback; also fixing up CALayer's internal gravity con…

4cb3ab2

…stant usage.

msft-Jeyaram mentioned this pull request Nov 8, 2016

Use the DisplayTexture interface implementation from UX when it's ready. #1337

Closed

jaredhms added 3 commits November 8, 2016 11:29

Incorporating PR feedback.

ab9f96f

Addressing more CR feedback.

6e60ff1

Fixing pre-existing cropping issues with UITextField.

6d10e3d

oliversa-msft reviewed Nov 9, 2016

View reviewed changes

Addressing more CR feedback.

12e0efc

jaredhms merged commit ec80479 into microsoft:ux/uxe Nov 9, 2016

jaredhms deleted the compositor_refactor branch November 9, 2016 22:11


		using namespace Microsoft::WRL;

		static const wchar_t* TAG = L"DisplayTexture";


		#import <algorithm>

		static const wchar_t* TAG = L"DisplayProperties";

		@@ -381,7 +381,9 @@ UIKIT_EXPORT_CLASS
		// WinObjC Xaml Extensions


		using namespace Microsoft::WRL;

		static const wchar_t* TAG = L"XamlCompositor";

Conversation

jaredhms commented Nov 4, 2016 • edited by rajsesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredhms commented Nov 4, 2016

Uh oh!

jaredhms commented Nov 4, 2016

Uh oh!

jaredhms commented Nov 4, 2016

Uh oh!

bbowman commented Nov 4, 2016 • edited by jaredhms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredhms commented Nov 4, 2016

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Nov 4, 2016 • edited by jaredhms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredhms Nov 4, 2016

Choose a reason for hiding this comment

Uh oh!

DHowett-MSFT Nov 4, 2016 • edited by jaredhms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aballway Nov 4, 2016 • edited by jaredhms Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jaredhms commented Nov 4, 2016 •

edited by rajsesh

Loading

bbowman commented Nov 4, 2016 •

edited by jaredhms

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

jaredhms Nov 4, 2016 •

edited

Loading

DHowett-MSFT Nov 4, 2016 •

edited by jaredhms

Loading

DHowett-MSFT Nov 4, 2016 •

edited by jaredhms

Loading

aballway Nov 4, 2016 •

edited by jaredhms

Loading

aballway Nov 4, 2016 •

edited by jaredhms

Loading

oliversa-msft Nov 7, 2016 •

edited by jaredhms

Loading

oliversa-msft Nov 8, 2016 •

edited by jaredhms

Loading

oliversa-msft commented Nov 8, 2016 •

edited by jaredhms

Loading

DHowett-MSFT Nov 8, 2016 •

edited by jaredhms

Loading

oliversa-msft Nov 9, 2016 •

edited by jaredhms

Loading