This repository was archived by the owner on May 28, 2025. It is now read-only.
Fixing heap corruption when using core text to draw into opaque layers.#1295
Merged
Merged
Conversation
The heap corruption happened in an internal test app. The fix is to use BGRX pixel format for opaque layers - this is supported by WIC render target.
Contributor
Author
|
@jaredhms is added to the review. #Closed |
|
|
aballway
approved these changes
Nov 2, 2016
jaredhms
reviewed
Nov 2, 2016
| // target = new CGVectorImage(width, height, _ColorBGR); | ||
| } else { | ||
| drawContext = _CGBitmapContextCreateWithFormat(width, height, _ColorBGR); | ||
| drawContext = _CGBitmapContextCreateWithFormat(width, height, _ColorBGRX); |
Contributor
There was a problem hiding this comment.
ight, _ColorBGRX); [](start = 76, length = 18)
how is this related to the heap corruption issue?
Contributor
Author
There was a problem hiding this comment.
We were allocating 3 bytes per pixel and writing into 4 essentially.
Contributor
|
|
1 similar comment
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing heap corruption when using core text to draw into opaque layers.
The heap corruption happened in an internal test app.
The fix is to use BGRX pixel format for opaque layers - this is supported
by WIC render target.
This change is