This repository was archived by the owner on May 28, 2025. It is now read-only.
[UIKit] [Xaml] Add Custom Text Edit Sample to XAMLCatalog#1257
Merged
Conversation
bbowman
reviewed
Oct 28, 2016
| <Properties> | ||
| <DisplayName>XAMLCatalog</DisplayName> | ||
| <PublisherDisplayName>pradipd</PublisherDisplayName> | ||
| <PublisherDisplayName>davelamb</PublisherDisplayName> |
Member
There was a problem hiding this comment.
I do sure wish there was something better we would do here. Its pretty silly that we don't just set this to winobjc or something.
Sample is based on CoreTextEditContext. It demonstrates: 1. Robustness of Xaml projections 2. Event registration and deregistration 3. Using a Xaml control to gain focus 4. Cooperative interoperability between Xaml and WinObjC 5. Custom input handling and rendering Certainly there are a few bugs, but the sample is intended to be used a stepping stone for adding custom text editing supoport to an Islandwood app.
|
|
||
| // This view's only subview is an autoresized UIView that hosts | ||
| // a Windows.UI.Xaml.ContentControl, which is used to gain focus, | ||
| // tabstop, and recieve pointer events. |
| - (void)_editContextCompositionCompleted:(WUTCCoreTextEditContext*)sender args:(WUTCCoreTextCompositionCompletedEventArgs*)e { | ||
| } | ||
|
|
||
| - (void)dealloc { |
Contributor
There was a problem hiding this comment.
Is it just me but I'd love to see the dealloc close to the init so I can compare the init/cleanup steps.
Contributor
Author
There was a problem hiding this comment.
As per coding spec. Will do. :)
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitely should check the code out and run it. It's certainly a bit of crazy. :)
This change is