This repository was archived by the owner on May 28, 2025. It is now read-only.
Fix Sample App with CAF Decoder#1252
Merged
Merged
Conversation
Description: A recent change regressed the CAF decoder work due to a few small issues. This change address those as follows: 1. Fixes subscript out of bounds on Debug due to misuse of reserve vs resize 2. Fixes divide by 0 due to incorrect struct size with variable length array. 3. Fixes infinite loop due to issue with setup of number of packets to read. That code is still incredibly obtuse for whats its doing and should be refactored at a later point for maintainability. How verified: Sample app launches now. There was much rejoicing.
rajsesh
approved these changes
Oct 27, 2016
aballway
approved these changes
Oct 27, 2016
| bytesLeftUntilChunkEnd -= [inStream read:(uint8_t*)&bytesToSkip[0] maxLength:chunkHeader.mChunkSize]; | ||
| if (chunkHeader.mChunkSize > 0) { | ||
| bytesToSkip.resize(chunkHeader.mChunkSize); | ||
| bytesLeftUntilChunkEnd -= [inStream read:(uint8_t*)&bytesToSkip[0] maxLength:chunkHeader.mChunkSize]; |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A recent change regressed the CAF decoder work due to a few small issues.
This change address those as follows:
code is still incredibly obtuse for whats its doing and should be refactored at a later
point for maintainability.
How verified:
Sample app launches now. There was much rejoicing.
This change is