This repository was archived by the owner on May 28, 2025. It is now read-only.
Change fonts used in unit tests to even more common ones#1234
Merged
Conversation
rajsesh
approved these changes
Oct 26, 2016
| UIFont* font = [UIFont fontWithName:@"Segoe UI" size:size]; | ||
| ASSERT_OBJCEQ(@"Segoe UI", [font fontName]); | ||
|
|
||
| ASSERT_NE(0, [font descender]); |
Contributor
Author
There was a problem hiding this comment.
out of scope for this review - this change is both time-sensitive, and due to the nature of the bug, I'd like to minimize risk and keep this change as small as possible. we can address other things if tests pass in the lab tonight, so please file non-showstopper feedback as separate issues.
In reply to: 85243923 [](ancestors = 85243923)
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1231
This change is