This repository was archived by the owner on May 28, 2025. It is now read-only.
Fix incorrect math surrounding text transforms in CGContextDrawGlyphRun#1188
Merged
Conversation
The text transforms were being incorrectly applied, directly concatenated onto the final transform. The text transform must be applied in text space (centered on the glyph run, inverted) Fixes microsoft#1113 Fixes microsoft#1135
aballway
approved these changes
Oct 19, 2016
rajsesh
reviewed
Oct 19, 2016
| // Technically there should be a horizontal translation to the center as well, | ||
| // but it's to the center of _each individual glyph_, as the reference platform applies the text matrix to each glyph individually | ||
| // Uncertain whether it's ever going to be worth it to support this using DWrite, so just ignore it for now | ||
| transform = CGAffineTransformConcat(CGAffineTransformMake(1, 0, 0, -1, 0, baselineCenterDelta), transform); |
Contributor
There was a problem hiding this comment.
You could skip the initial CGAffineTransformConcat since transform is identity. #Resolved
Contributor
There was a problem hiding this comment.
Or rather: CGAffineTransform transform = CGAffineTransformMake(...);
In reply to: 84172077 [](ancestors = 84172077)
|
So this anchors the bottom left of the text at the text position? |
|
|
Contributor
Author
|
More or less yes. At the baseline instead of the bottom/top left corner though. In reply to: 254951164 [](ancestors = 254951164) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text transforms were being incorrectly applied, directly concatenated onto the final transform.
The text transform must be applied in text space (centered on the glyph run, inverted)
Fixes #1113
Fixes #1135