This repository was archived by the owner on May 28, 2025. It is now read-only.
Do not roam NSUserDefaults (or CFPreferences)#1169
Merged
Conversation
rajsesh
commented
Oct 18, 2016
Contributor
added 2 commits
October 17, 2016 19:33
App preferences writes with kCFPreferencesAnyHost, which means we cannot use the host parameter to differentiate roaming vs local. The correct way to roam would be through ubiquitous store (which would have to be covered separately based on need). Fix #1167
Contributor
Author
|
@DHowett-MSFT is added to the review. #Closed |
Contributor
Author
|
@bbowman is added to the review. #Closed |
|
|
||
| // WINOBJC: make sure that nFolder is CSIDL_APPDATA or CSIDL_LOCAL_APPDATA and return the app data folder for the app. | ||
| Wrappers::HString path = GetAppDataPath(nFolder == CSIDL_LOCAL_APPDATA); | ||
| //WinOBJC- In Reference platform, CFPreferences does not roam, so ignore nFolder |
There was a problem hiding this comment.
Nit: keep the style of the above comment (WINOBJC:) #Pending
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.