Add Readme.md for the virtualization states of a file#1657
Merged
kewillford merged 1 commit intomicrosoft:masterfrom Apr 20, 2020
Merged
Add Readme.md for the virtualization states of a file#1657kewillford merged 1 commit intomicrosoft:masterfrom
kewillford merged 1 commit intomicrosoft:masterfrom
Conversation
jrbriggs
approved these changes
Apr 17, 2020
Member
jrbriggs
left a comment
There was a problem hiding this comment.
This is a great high-level overview. Just a couple of suggestions.
| 1. ProjFS remove the reparse point so file is a NTFS file. | ||
| 2. ProjFS calls `OnNotifyFilePreConvertToFull`. | ||
| 3. VFSForGit if path is projected | ||
| 1. Adds path to the modified paths so git will keep it up to date. |
Member
There was a problem hiding this comment.
Adding to the modified path database happens regardless of whether the path is projected, yeah?
Member
Author
There was a problem hiding this comment.
Nope there is a check to make sure it is in the projection. The reason is that the PreConvertToFull "should" only be called for files that are in the projection. If it was for some other file, that file would have been added to the modified paths via the OnNotifyNewFileCreated
a320dc3 to
e3351f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial document for how the virtualization works on the Windows side. There is still a lot of scenarios that are not covered in this document but it is a good starting point I hope.