GVFS.Service should copy ProjectedFSLib.dll when it's missing and the installed ProjFS version matches the packaged version#1073
Merged
wilbaker merged 5 commits intomicrosoft:masterfrom Apr 30, 2019
Conversation
…on machine matches version in package
jeschu1
reviewed
Apr 26, 2019
jeschu1
reviewed
Apr 26, 2019
jamill
reviewed
Apr 29, 2019
jamill
suggested changes
Apr 29, 2019
Member
jamill
left a comment
There was a problem hiding this comment.
Main question was about setting error message when unable to copy over native prjflt
jamill
reviewed
Apr 29, 2019
wilbaker
commented
Apr 29, 2019
…d fix TryEnablePrjFlt return value
jamill
reviewed
Apr 30, 2019
jamill
approved these changes
Apr 30, 2019
GVFS/GVFS.UnitTests.Windows/Windows/Platform/ProjFSFilterTests.cs
Outdated
Show resolved
Hide resolved
derrickstolee
approved these changes
Apr 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127, fixes #423
Updated GVFS.Service so that if the native ProjFS library is missing and the installed version of prjflt matches the version that ships with VFS4G, GVFS.Service will copy the native ProjFS library into
C:\Program Files\GVFS.Manual testing
Installed the non-inbox ProjFS that ships with VFS4G and removed ProjectedFSLib.dll. Restarted GVFS.Service and verified that it copied
ProjectedFSLib.dllfromC:\Program Files\GVFS\ProjFStoC:\Program Files\GVFS.Installed an older version of the ProjFS driver and removed ProjectedFSLib.dll. Restarted GVFS.Service and verified that it did not copy
ProjectedFSLib.dllbecause the packaged prjflt version didn't match the installed prjflt version.