Skip to content

Upgrade to new ProjFS versions#1068

Merged
jeschu1 merged 1 commit intomicrosoft:masterfrom
jeschu1:new_projfs
Apr 29, 2019
Merged

Upgrade to new ProjFS versions#1068
jeschu1 merged 1 commit intomicrosoft:masterfrom
jeschu1:new_projfs

Conversation

@jeschu1
Copy link
Member

@jeschu1 jeschu1 commented Apr 25, 2019

No description provided.

@jeschu1 jeschu1 requested a review from wilbaker April 26, 2019 12:54
<Reference Include="ProjectedFSLib.Managed, Version=1.0.19079.1, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=AMD64">
<HintPath>..\..\..\packages\$(ProjFSManagedPackage)\lib\net461\ProjectedFSLib.Managed.dll</HintPath>
<Reference Include="ProjectedFSLib.Managed, Version=1.0.19108.2, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=AMD64">
<HintPath>..\..\..\packages\Microsoft.Windows.ProjFS.1.0.19108.2\lib\net461\ProjectedFSLib.Managed.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a big deal, but I see that $(ProjFSManagedPackage) was replaced with a hardcoded Microsoft.Windows.ProjFS.1.0.19108.2. If this was done automatically by the IDE when we upgraded I think that's okay.

(Noticed this in a few files)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the IDE. Since we'll likely use the IDE to upgrade next time I think it's OK change, like you are suggesting.

@jeschu1 jeschu1 merged commit c16587b into microsoft:master Apr 29, 2019
@jrbriggs jrbriggs added this to the M151 milestone May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants