Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
We still depend on that, so we can't just remove it until we get a new mdn/content dependency? |
I know |
|
Hello @saschanaz, |
|
Maybe |
Hello:) |
|
I mean |
|
jakebailey
left a comment
There was a problem hiding this comment.
Theoretically seems good to me; @saschanaz seem alright as a first go?
|
Hi @saschanaz, @jakebailey, @sandersn 👋 I've looked into ways to clone only specific parts of a repo without fetching the entire repository. Git doesn't support this natively, but I found a practical workaround using SVN (Subversion). Although it's an older tool, it’s still supported by GitHub and allows downloading a single directory without pulling the whole repo. This might be a viable solution for our case—just wanted to share as a proposal for consideration. |
|
I don't think we need to do anything fancy. The submodule is fine. |
Okay, do you have any estimation of when this pr will be merged? |
|
SVN is not supported by GitHub https://github.blog/news-insights/product-news/sunsetting-subversion-support/ (I'm pretty surprised that it was supported at all) |
|
I see no blocker to not merge. |
Good to know, I didn't know
Me too. Can you merge it? |
|
I mean only if I could... 🤷🏻♀️ LGTM |
|
Sorry @saschanaz, you don't have access to these files: |
|
Hello @jakebailey |
|
I'll merge it now, I had just replied late at night 😄 |
Thank you very much for merging this huge PR. You just made my day :) |
fixes #1937