Skip to content

Use printUnifiedDiff for faster diffing#1581

Merged
sandersn merged 1 commit intomicrosoft:mainfrom
saschanaz:unified-diff
Jun 20, 2023
Merged

Use printUnifiedDiff for faster diffing#1581
sandersn merged 1 commit intomicrosoft:mainfrom
saschanaz:unified-diff

Conversation

@saschanaz
Copy link
Copy Markdown
Collaborator

This is really for debugging purpose than anything else, so whatever performs faster fits here.

Fixes #1580.

This is really for debugging purpose than anything else, so whatever performs faster fits here.
@saschanaz
Copy link
Copy Markdown
Collaborator Author

Somehow the maintainers assignation is not happening?

LGTM?

@github-actions
Copy link
Copy Markdown
Contributor

Sorry @saschanaz, you don't have access to these files: * /deploy/deployChangedPackages.js.

@saschanaz saschanaz changed the title Use printUnifiedDiff for faster diffing Use printUnifiedDiff for faster diffing [maintainers] Jun 20, 2023
@saschanaz
Copy link
Copy Markdown
Collaborator Author

Manually pinging @sandersn since the automation doesn't work 🤔

@RyanCavanaugh RyanCavanaugh requested a review from sandersn June 20, 2023 22:27
@saschanaz saschanaz changed the title Use printUnifiedDiff for faster diffing [maintainers] Use printUnifiedDiff for faster diffing Jun 20, 2023
@sandersn sandersn merged commit de802e9 into microsoft:main Jun 20, 2023
@sandersn
Copy link
Copy Markdown
Member

I'm about to quit work for the night, so I'll let this run on its normal schedule to see if this PR fixes the timeout.

@saschanaz saschanaz deleted the unified-diff branch June 21, 2023 09:01
@saschanaz
Copy link
Copy Markdown
Collaborator Author

And it worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The NPM deploy job fails on print-diff

2 participants