Skip to content

Add fast path exits if we are retaining all configured projects#59689

Merged
sheetalkamat merged 1 commit intomainfrom
orphanProjects
Aug 20, 2024
Merged

Add fast path exits if we are retaining all configured projects#59689
sheetalkamat merged 1 commit intomainfrom
orphanProjects

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat commented Aug 19, 2024

If we are retaining all configured projects adds multiple checks for early exits instead of iterating through all open files

Possibly fixes #59335

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 19, 2024
@sheetalkamat
Copy link
Copy Markdown
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Aug 19, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Aug 19, 2024

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163379/artifacts?artifactName=tgz&fileId=DB07ADC14099E408AFC3DBBEC11EC9732D00FF6B99DCA0A926B01F338FC3723D02&fileName=/typescript-5.6.0-insiders.20240819.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.6.0-pr-59689-2".;

@sheetalkamat sheetalkamat marked this pull request as ready for review August 20, 2024 16:31
@sheetalkamat sheetalkamat changed the title [Experiment] Add fast path exits if we are retaining all configured projects Add fast path exits if we are retaining all configured projects Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚡ Performance: Project service spends excess time cleaning client files when called synchronously

3 participants