🤖 Pick PR #59026 (fix(59011): TypeScript generates in...) into release-5.5#59039
Merged
DanielRosenwasser merged 1 commit intorelease-5.5from Jul 16, 2024
Merged
Conversation
Member
|
@DanielRosenwasser I merged the original PR. I don't know if you still want this for a 5.5 patch (if there is going to be another one). |
Member
|
There's definitely going to be a 5.5 patch; we have 15 open backports! |
Member
|
Anyone know what the deal is with that assertion error on Node 20? |
Member
|
Spurious failure due to the symlink tests. @sheetalkamat You can just restart the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #59026.
Please review the diff and merge if no changes are unexpected.