Implementing copy/paste #57262
Implementing copy/paste #57262
Conversation
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
tests/cases/fourslash/server/postPasteImportFix_multiplePastes2.ts
Outdated
Show resolved
Hide resolved
mjbvz
left a comment
There was a problem hiding this comment.
Just reviewed the protocol changes. Direction looks good but had a few suggestions for using different types
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
Trying to dismiss this to see if it enables merging. Right now its blocked
|
@DanielRosenwasser @navya9singh wasnt able to merge because it was marked as pending your review and you are oof. And the feedback seems to be addressed |
Fixes #50187