Pull back esfx dependencies to fix error in gulpfile#50656
Closed
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
Closed
Pull back esfx dependencies to fix error in gulpfile#50656jakebailey wants to merge 1 commit intomicrosoft:mainfrom
jakebailey wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
Author
|
I sent #50658 as well, with my other potential fix if we're okay just dropping the dep. |
sheetalkamat
approved these changes
Sep 6, 2022
Member
Author
|
I took #50658 instead. |
Contributor
|
FYI, I think fixed the missing file issues in esfx in |
Member
Author
|
I did test pre.34, and it wasn't fixed there, unfortunately. See: https://unpkg.com/browse/@esfx/disposable@1.0.0-pre.34/dist/cjs/ |
Contributor
|
What is missing? |
Member
Author
|
The And line 19 here: https://unpkg.com/browse/@esfx/disposable@1.0.0-pre.34/dist/cjs/disposable.js |
Contributor
|
Ah, ok thanks. |
Contributor
|
That should now be fixed in 1.0.0-pre.36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
66fbf05 updated dependencies, which included esfx stuff, but it appears as though the packages are missing files as of esfx/esfx@be78c9e.
Use overrides to temporarily pull these back to working versions.
We only use these via "prex", for cancellation during the build, but as far as I can tell, we never give anything a cancellation token, so potentially we could just remove cancellation altogether as a fix too.