Add an action to update baselines/fix lints#39898
Conversation
|
|
||
| - name: Configure Git, Run Tests, Update Baselines, Apply Fixes | ||
| run: | | ||
| git config user.email "ts_bot@rcavanaugh.com" |
There was a problem hiding this comment.
So all of our actions do this. Two things:
- Do we have a Microsoft account we can use @RyanCavanaugh?
- Is there a way to use the person who triggered the action's email?
There was a problem hiding this comment.
- typescriptbot@microsoft.com
- I believe
${{github.actor}}@users.noreply.github.comshould do the trick
There was a problem hiding this comment.
I believe
${{github.actor}}@users.noreply.github.comshould do the trick
I think if your account isn't old enough, you have to use something like a special user ID email.
If you created your GitHub account after July 18, 2017, your GitHub-provided no-reply email address is a seven-digit ID number and your username in the form of
ID+username@users.noreply.github.com. If you created your GitHub account prior to July 18, 2017, your GitHub-provided no-reply email address is your username in the form ofusername@users.noreply.github.com. You can get an ID-based GitHub-provided no-reply email address by selecting (or deselecting and reselecting) Keep my email address private in your email settings.
|
I am assuming we can do this on PR or a branch and would make life so much easier to just accept baselines or fix lint errors rather than having to do them locally after finding out from bigger run |
|
I don't think the action will work on PRs from forks in this form. |
|
May be make it bot work then ? |
|
I think this is useful enough for team PRs. |
Fixes #37765
The workflow will more or less look like this