Skip to content

Handle parentless nodes in isParameterPropertyDeclaration#33472

Merged
DanielRosenwasser merged 1 commit intomasterfrom
parentNodesPortMaster
Sep 17, 2019
Merged

Handle parentless nodes in isParameterPropertyDeclaration#33472
DanielRosenwasser merged 1 commit intomasterfrom
parentNodesPortMaster

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

Ports #33321 into master, fixes #33295.

Fixes #33295.

This follows a similar pattern as in #20314 by requiring an explicit
`parent` parameter. Where possible, it uses the appopriate variable at
the call sites.

In several locations there is no context available though (e.g.
inspecting `valueDeclarations`) and we access `.parent` as the code
previously did. From a cursory inspection this seems correct, these
callpaths originate in phases where there must be a `parent` (i.e. in
checker, binder, etc).

Change-Id: I28e4726777b57237bec776e4001e9e69ac591b11
@DanielRosenwasser DanielRosenwasser merged commit a58b86b into master Sep 17, 2019
@DanielRosenwasser DanielRosenwasser deleted the parentNodesPortMaster branch September 17, 2019 20:56
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: 3.6 crashes if constructor parameters transformed

3 participants