Skip to content

Cherry picking #33145 to release-3.6#33170

Merged
sheetalkamat merged 1 commit intorelease-3.6from
builderCircularity3.6
Aug 31, 2019
Merged

Cherry picking #33145 to release-3.6#33170
sheetalkamat merged 1 commit intorelease-3.6from
builderCircularity3.6

Conversation

@sheetalkamat
Copy link
Member

Handle seenEmittedFiles which was not being set when emit of a file was complete (#33145)

  • Add test that fails because file is written multiple times
    Reported from Prevent excessive compilation of files within a cycle #33061

  • Handle seenEmittedFiles which was not being set when emit of a file was complete.
    It was issue only when errors are reported before emitting (which puts the files into pendingEmit that needs to check only in seenEmittedFiles)
    If emit happens before semantic diagnostics query this issue is not repro, because the affected files come into play and those are being set correctly
    Fixes tsc instance reuse in composite project causes out of memory crash #31398

  • make baselining source map optional

  • Handle emitDeclarationOnly in --build scenario

  • Ensure we are using d.ts emit as signature even when --declarationMap is on (map files are emitted before d.ts)

  • Move module specifiers to verifyTsBuildOutput

  • implement create Hash to be default hashing plus data so we can verify it easily in baseline

  • Remove failing baseline

  • Accept correct baseline name

implement create Hash to be default hashing plus data so we can verify it easily in baseline
@sheetalkamat sheetalkamat changed the title Cherry picking #33145 Cherry picking #33145 to release-3.6 Aug 30, 2019
@sheetalkamat sheetalkamat merged commit 4aad78b into release-3.6 Aug 31, 2019
@sheetalkamat sheetalkamat deleted the builderCircularity3.6 branch August 31, 2019 01:02
@ericanderson
Copy link
Contributor

@sheetalkamat can we get an rc for 3.6.3?

@ericanderson
Copy link
Contributor

@typescript-bot pack this

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants