Skip to content

Conversation

@RyanCavanaugh
Copy link
Member

Fixes #31074

@RyanCavanaugh RyanCavanaugh merged commit 885d4d6 into microsoft:master Apr 23, 2019
@RyanCavanaugh RyanCavanaugh deleted the removeDeadCode branch April 23, 2019 20:51
@FredKSchott
Copy link

Just for future reference, is the entire public ts interface not considered stable? This PR removed the generateTypesForModule method from the public interface which broke a Pika plugin that had been built on top of it.

@weswigham weswigham added the Breaking Change Would introduce errors in existing code label Jul 15, 2019
@weswigham
Copy link
Member

weswigham commented Jul 15, 2019

TS doesn't follow semver, so "stability" is relative... however we did fail to flag this removal as a breaking change upon release, yes. I don't think we really intended to the methods to be public prior to their completion and vetting really, anyway :S

dts-gen should have the same functionality available, tho, as that's where it was taken from ❤️

@FredKSchott
Copy link

No worries, appreciate the clarification 👍

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Breaking Change Would introduce errors in existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove value inspection code

3 participants