-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Open
Labels
Domain: LS: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Relates to go-to-definition, find-all-references, highlighting/occurrences.Experience EnhancementNoncontroversial enhancementsNoncontroversial enhancementsHelp WantedYou can do thisYou can do thisSuggestionAn idea for TypeScriptAn idea for TypeScript
Milestone
Description
🔎 Search Terms
key remapping breaks goto definition navigation mapped type
key remap goto def
breaks definition navigation
🕗 Version & Regression Information
- This changed between versions 4.3.5 and 4.4.4
This looks like a regression of the resolution from #47813.
⏯ Playground Link
💻 Code
interface Foo {
property: string
}
type MapItWithRemap<T> = {[P in keyof T as P extends string ? `mapped_${P}` : never]: 0}
{
let gotoDef!: MapItWithRemap<Foo>
// 0 - 4.0.5 not supported
// 4.1.5 - 4.3.5 ok
// 4.4.4+ "no definition found for 'mapped_property'"
gotoDef.mapped_property
}🙁 Actual behavior
goto definition cannot find originating property declaration
🙂 Expected behavior
goto definition can find originating property declaration
Additional information about the issue
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Domain: LS: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Relates to go-to-definition, find-all-references, highlighting/occurrences.Experience EnhancementNoncontroversial enhancementsNoncontroversial enhancementsHelp WantedYou can do thisYou can do thisSuggestionAn idea for TypeScriptAn idea for TypeScript