String#matchAll should return iterable of RegExpExecArray (fixes #36788)

nihil-admirari · nihil-admirari · commit d0be0cd1cefa · 2023-08-29T23:23:19.000+03:00
diff --git a/src/lib/es2020.string.d.ts b/src/lib/es2020.string.d.ts
@@ -6,5 +6,5 @@ interface String {
      * containing the results of that search.
      * @param regexp A variable name or string literal containing the regular expression pattern and flags.
      */
-    matchAll(regexp: RegExp): IterableIterator<RegExpMatchArray>;
+    matchAll(regexp: RegExp): IterableIterator<RegExpExecArray>;
 }
diff --git a/tests/baselines/reference/stringMatchAll.types b/tests/baselines/reference/stringMatchAll.types
@@ -2,23 +2,23 @@
 
 === stringMatchAll.ts ===
 const matches = "matchAll".matchAll(/\w/g);
->matches : IterableIterator<RegExpMatchArray>
->"matchAll".matchAll(/\w/g) : IterableIterator<RegExpMatchArray>
->"matchAll".matchAll : (regexp: RegExp) => IterableIterator<RegExpMatchArray>
+>matches : IterableIterator<RegExpExecArray>
+>"matchAll".matchAll(/\w/g) : IterableIterator<RegExpExecArray>
+>"matchAll".matchAll : (regexp: RegExp) => IterableIterator<RegExpExecArray>
 >"matchAll" : "matchAll"
->matchAll : (regexp: RegExp) => IterableIterator<RegExpMatchArray>
+>matchAll : (regexp: RegExp) => IterableIterator<RegExpExecArray>
 >/\w/g : RegExp
 
 const array = [...matches];
->array : RegExpMatchArray[]
->[...matches] : RegExpMatchArray[]
->...matches : RegExpMatchArray
->matches : IterableIterator<RegExpMatchArray>
+>array : RegExpExecArray[]
+>[...matches] : RegExpExecArray[]
+>...matches : RegExpExecArray
+>matches : IterableIterator<RegExpExecArray>
 
 const { index, input } = array[0];
 >index : number
 >input : string
->array[0] : RegExpMatchArray
->array : RegExpMatchArray[]
+>array[0] : RegExpExecArray
+>array : RegExpExecArray[]
 >0 : 0
 

Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,5 @@ interface String {`
`6`	`6`	`* containing the results of that search.`
`7`	`7`	`* @param regexp A variable name or string literal containing the regular expression pattern and flags.`
`8`	`8`	`*/`
`9`		`- matchAll(regexp: RegExp): IterableIterator<RegExpMatchArray>;`
	`9`	`+ matchAll(regexp: RegExp): IterableIterator<RegExpExecArray>;`
`10`	`10`	`}`