Fix tests with new errors from types default change

Copilot · RyanCavanaugh · Copilot · commit 83af77128d29 · 2026-01-22T18:03:55.000Z
Added explicit types arrays to tests that now have new errors: - moduleResolution_automaticTypeDirectiveNames: types: ["a"] - referenceTypesPreferedToPathIfPossible: types: ["node"] - typeRootsFromMultipleNodeModulesDirectories: types: ["dopey", "grumpy", "sneezy"] - typeRootsFromNodeModulesInParentDirectory: types: ["foo"] - typingsLookup3: types: ["jquery"] These tests relied on automatic @types inclusion and now require explicit configuration. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
diff --git a/tests/baselines/reference/typingsLookup3.errors.txt b/tests/baselines/reference/typingsLookup3.errors.txt
@@ -1,17 +1,14 @@
 /a.ts(1,23): error TS2688: Cannot find type definition file for 'JqUeRy'.
-/a.ts(2,1): error TS2581: Cannot find name '$'. Do you need to install type definitions for jQuery? Try `npm i --save-dev @types/jquery`.
 
 
 ==== /tsconfig.json (0 errors) ====
-    { "files": "a.ts" }
+    { "files": "a.ts", "compilerOptions": { "types": ["jquery"] } }
     
-==== /a.ts (2 errors) ====
+==== /a.ts (1 errors) ====
     /// <reference types="JqUeRy" />
                           ~~~~~~
 !!! error TS2688: Cannot find type definition file for 'JqUeRy'.
     $.x;
-    ~
-!!! error TS2581: Cannot find name '$'. Do you need to install type definitions for jQuery? Try `npm i --save-dev @types/jquery`.
     
 ==== /node_modules/@types/jquery/index.d.ts (0 errors) ====
     declare var $: { x: any };
diff --git a/tests/baselines/reference/typingsLookup3.symbols b/tests/baselines/reference/typingsLookup3.symbols
@@ -1,7 +1,14 @@
 //// [tests/cases/conformance/typings/typingsLookup3.ts] ////
 
 === /a.ts ===
-
 /// <reference types="JqUeRy" />
 $.x;
+>$.x : Symbol(x, Decl(index.d.ts, 0, 16))
+>$ : Symbol($, Decl(index.d.ts, 0, 11))
+>x : Symbol(x, Decl(index.d.ts, 0, 16))
+
+=== /node_modules/@types/jquery/index.d.ts ===
+declare var $: { x: any };
+>$ : Symbol($, Decl(index.d.ts, 0, 11))
+>x : Symbol(x, Decl(index.d.ts, 0, 16))
 
diff --git a/tests/baselines/reference/typingsLookup3.trace.json b/tests/baselines/reference/typingsLookup3.trace.json
@@ -5,5 +5,15 @@
     "Searching all ancestor node_modules directories for preferred extensions: Declaration.",
     "File '/node_modules/JqUeRy.d.ts' does not exist.",
     "File '/node_modules/@types/JqUeRy.d.ts' does not exist.",
-    "======== Type reference directive 'JqUeRy' was not resolved. ========"
+    "======== Type reference directive 'JqUeRy' was not resolved. ========",
+    "======== Resolving type reference directive 'jquery', containing file '/__inferred type names__.ts', root directory '/node_modules/@types'. ========",
+    "Resolving with primary search path '/node_modules/@types'.",
+    "File '/node_modules/@types/jquery/package.json' does not exist.",
+    "File '/node_modules/@types/jquery/index.d.ts' exists - use it as a name resolution result.",
+    "Resolving real path for '/node_modules/@types/jquery/index.d.ts', result '/node_modules/@types/jquery/index.d.ts'.",
+    "======== Type reference directive 'jquery' was successfully resolved to '/node_modules/@types/jquery/index.d.ts', primary: true. ========",
+    "File '/node_modules/@types/jquery/package.json' does not exist according to earlier cached lookups.",
+    "File '/node_modules/@types/package.json' does not exist.",
+    "File '/node_modules/package.json' does not exist.",
+    "File '/package.json' does not exist."
 ]
diff --git a/tests/baselines/reference/typingsLookup3.types b/tests/baselines/reference/typingsLookup3.types
@@ -5,8 +5,15 @@
 $.x;
 >$.x : any
 >    : ^^^
->$ : any
+>$ : { x: any; }
+>  : ^^^^^   ^^^
+>x : any
 >  : ^^^
+
+=== /node_modules/@types/jquery/index.d.ts ===
+declare var $: { x: any };
+>$ : { x: any; }
+>  : ^^^^^   ^^^
 >x : any
 >  : ^^^
 
diff --git a/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts b/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts
@@ -1,4 +1,5 @@
 // @noImplicitReferences: true
+// @types: a
 
 // @Filename: /node_modules/@types/.a/index.d.ts
 declare const a: number;
diff --git a/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts b/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts
@@ -1,5 +1,6 @@
 // @declaration: true
 // @noImplicitReferences: true
+// @types: node
 // @filename: /.src/node_modules/@types/node/index.d.ts
 declare module "url" {
     export class Url {}
diff --git a/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts b/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts
@@ -24,4 +24,4 @@ import { z } from "abc";
 x + y + z;
 
 // @Filename: /foo/bar/tsconfig.json
-{}
+{ "compilerOptions": { "types": ["dopey", "grumpy", "sneezy"] } }
diff --git a/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts b/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts
@@ -12,4 +12,4 @@ import { x } from "xyz";
 x;
 
 // @Filename: /src/tsconfig.json
-{}
+{ "compilerOptions": { "types": ["foo"] } }
diff --git a/tests/cases/conformance/typings/typingsLookup3.ts b/tests/cases/conformance/typings/typingsLookup3.ts
@@ -4,7 +4,7 @@
 // This tests that `types` references are not lowercased.
 
 // @filename: /tsconfig.json
-{ "files": "a.ts" }
+{ "files": "a.ts", "compilerOptions": { "types": ["jquery"] } }
 
 // @filename: /node_modules/@types/jquery/index.d.ts
 declare var $: { x: any };

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`// @noImplicitReferences: true`
	`2`	`+// @types: a`
`2`	`3`
`3`	`4`	`// @Filename: /node_modules/@types/.a/index.d.ts`
`4`	`5`	`declare const a: number;`