Support wildcard exports in tsconfig lookup

andrewbranch · andrewbranch · commit 6885ed39a697 · 2023-03-22T15:02:18.000-07:00
diff --git a/src/compiler/moduleNameResolver.ts b/src/compiler/moduleNameResolver.ts
@@ -1689,7 +1689,7 @@ export function nodeModuleNameResolver(moduleName: string, containingFile: strin
 
 /** @internal */
 export function nodeNextJsonConfigResolver(moduleName: string, containingFile: string, host: ModuleResolutionHost): ResolvedModuleWithFailedLookupLocations {
-    return nodeModuleNameResolverWorker(NodeResolutionFeatures.Exports, moduleName, getDirectoryPath(containingFile), { moduleResolution: ModuleResolutionKind.NodeNext }, host, /*cache*/ undefined, Extensions.Json, /*isConfigLookup*/ true, /*redirectedReference*/ undefined);
+    return nodeModuleNameResolverWorker(NodeResolutionFeatures.NodeNextDefault, moduleName, getDirectoryPath(containingFile), { moduleResolution: ModuleResolutionKind.NodeNext }, host, /*cache*/ undefined, Extensions.Json, /*isConfigLookup*/ true, /*redirectedReference*/ undefined);
 }
 
 function nodeModuleNameResolverWorker(features: NodeResolutionFeatures, moduleName: string, containingDirectory: string, compilerOptions: CompilerOptions, host: ModuleResolutionHost, cache: ModuleResolutionCache | undefined, extensions: Extensions, isConfigLookup: boolean, redirectedReference: ResolvedProjectReference | undefined): ResolvedModuleWithFailedLookupLocations {
diff --git a/tests/baselines/reference/tsconfigExtendsPackageJsonExportsWildcard.errors.txt b/tests/baselines/reference/tsconfigExtendsPackageJsonExportsWildcard.errors.txt
@@ -0,0 +1,30 @@
+/index.ts(2,1): error TS2454: Variable 'x' is used before being assigned.
+
+
+==== /tsconfig.json (0 errors) ====
+    {
+        "extends": "foo/strict.json"
+    }
+    
+==== /node_modules/foo/package.json (0 errors) ====
+    {
+        "name": "foo",
+        "version": "1.0.0",
+        "exports": {
+            "./*.json": "./configs/*.json"
+        }
+    }
+    
+==== /node_modules/foo/configs/strict.json (0 errors) ====
+    {
+        "compilerOptions": {
+            "strict": true
+        }
+    }
+    
+==== /index.ts (1 errors) ====
+    let x: string;
+    x.toLowerCase();
+    ~
+!!! error TS2454: Variable 'x' is used before being assigned.
+    
diff --git a/tests/cases/compiler/tsconfigExtendsPackageJsonExportsWildcard.ts b/tests/cases/compiler/tsconfigExtendsPackageJsonExportsWildcard.ts
@@ -0,0 +1,27 @@
+// @noTypesAndSymbols: true
+// @noEmit: true
+
+// @Filename: /node_modules/foo/package.json
+{
+    "name": "foo",
+    "version": "1.0.0",
+    "exports": {
+        "./*.json": "./configs/*.json"
+    }
+}
+
+// @Filename: /node_modules/foo/configs/strict.json
+{
+    "compilerOptions": {
+        "strict": true
+    }
+}
+
+// @Filename: /tsconfig.json
+{
+    "extends": "foo/strict.json"
+}
+
+// @Filename: /index.ts
+let x: string;
+x.toLowerCase();

Original file line number	Diff line number	Diff line change
`@@ -1689,7 +1689,7 @@ export function nodeModuleNameResolver(moduleName: string, containingFile: strin`
`1689`	`1689`
`1690`	`1690`	`/** @internal */`
`1691`	`1691`	`export function nodeNextJsonConfigResolver(moduleName: string, containingFile: string, host: ModuleResolutionHost): ResolvedModuleWithFailedLookupLocations {`
`1692`		`- return nodeModuleNameResolverWorker(NodeResolutionFeatures.Exports, moduleName, getDirectoryPath(containingFile), { moduleResolution: ModuleResolutionKind.NodeNext }, host, /cache/ undefined, Extensions.Json, /isConfigLookup/ true, /redirectedReference/ undefined);`
	`1692`	`+ return nodeModuleNameResolverWorker(NodeResolutionFeatures.NodeNextDefault, moduleName, getDirectoryPath(containingFile), { moduleResolution: ModuleResolutionKind.NodeNext }, host, /cache/ undefined, Extensions.Json, /isConfigLookup/ true, /redirectedReference/ undefined);`
`1693`	`1693`	`}`
`1694`	`1694`
`1695`	`1695`	`function nodeModuleNameResolverWorker(features: NodeResolutionFeatures, moduleName: string, containingDirectory: string, compilerOptions: CompilerOptions, host: ModuleResolutionHost, cache: ModuleResolutionCache \| undefined, extensions: Extensions, isConfigLookup: boolean, redirectedReference: ResolvedProjectReference \| undefined): ResolvedModuleWithFailedLookupLocations {`