Skip to content

Disable warning C4648 'standard attribute 'meow' is ignored'#672

Merged
CaseyCarter merged 1 commit intomicrosoft:masterfrom
aymarino:disable-c4648
Apr 1, 2020
Merged

Disable warning C4648 'standard attribute 'meow' is ignored'#672
CaseyCarter merged 1 commit intomicrosoft:masterfrom
aymarino:disable-c4648

Conversation

@aymarino
Copy link
Contributor

@aymarino aymarino commented Apr 1, 2020

Description

In a future release of MSVC, the compiler warns with C4648 on uses of standard attribute [[no_unique_address]], which is recognized by but not yet implemented in the compiler. Since <algorithm> intentionally uses the attribute, disable the warning in STL headers. This mirrors changes in DevDiv internal MSVC-PR-239026.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@aymarino aymarino requested a review from a team as a code owner April 1, 2020 22:26
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 1, 2020
@CaseyCarter CaseyCarter merged commit dba4ef9 into microsoft:master Apr 1, 2020
@CaseyCarter
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants