Changing VCLIBS_SUFFIX to be a cache CMake variable#649
Merged
cbezault merged 2 commits intomicrosoft:masterfrom Apr 1, 2020
Merged
Changing VCLIBS_SUFFIX to be a cache CMake variable#649cbezault merged 2 commits intomicrosoft:masterfrom
cbezault merged 2 commits intomicrosoft:masterfrom
Conversation
cbezault
approved these changes
Mar 28, 2020
BillyONeal
approved these changes
Mar 28, 2020
Member
BillyONeal
left a comment
There was a problem hiding this comment.
I double checked that this variable isn't used in the name of any targets or similar so it probably should work if someone changes it after the fact.
I still find this idea of editing cache variables after the fact a bit ... broken but there's no reason to prevent attempts at working where it might.
CaseyCarter
suggested changes
Mar 29, 2020
StephanTLavavej
approved these changes
Mar 29, 2020
Co-Authored-By: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Mar 30, 2020
StephanTLavavej
approved these changes
Mar 30, 2020
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
VCLIBS_SUFFIXis not a cache variable and as a result, users can not change it via the cmake command line. This PR changes it to cache variable.Closes #115
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.