Disallow specializing bitset and ratio#5937
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Dec 8, 2025
Merged
Conversation
AlexGuteniev
reviewed
Dec 5, 2025
StephanTLavavej
approved these changes
Dec 5, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🙅 0️⃣ 1️⃣ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::bitsetorstd::ratioonly take constant template parameters, so none of their specialization can depend on a type. As a result, although they are not explicitly disallowed to be specialized, it is impossible to provide any valid program-defined specialization.It's not very clear to me whether it's OK to reject all program-defined
ratio_addspecializations and their friends. It seems that there can be valid program-definedratio_addpartial specializations that are always ill-formed on instantiation due tostatic_assert, which is squirrelly🐿️.