Skip to content

Remove comments after LWG-3454 "pointer_traits::pointer_to should be constexpr" was accepted#5909

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
vmichal:pointer_traits-pointer_to-constexpr
Nov 27, 2025
Merged

Remove comments after LWG-3454 "pointer_traits::pointer_to should be constexpr" was accepted#5909
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
vmichal:pointer_traits-pointer_to-constexpr

Conversation

@vmichal
Copy link
Contributor

@vmichal vmichal commented Nov 25, 2025

Only one reference was found and removed at

STL/stl/inc/xutility

Lines 626 to 629 in 5459853

_NODISCARD static _CONSTEXPR20 pointer pointer_to(_Reftype _Val)
noexcept(noexcept(_Ty::pointer_to(_Val))) /* strengthened */ { // Per LWG-3454
return _Ty::pointer_to(_Val);
}

Fixes #5864

@vmichal vmichal requested a review from a team as a code owner November 25, 2025 11:06
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Nov 25, 2025
@StephanTLavavej StephanTLavavej added documentation Related to documentation or comments LWG Library Working Group issue labels Nov 25, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Nov 25, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Nov 25, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5ee5b61 into microsoft:main Nov 27, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Nov 27, 2025
@StephanTLavavej
Copy link
Member

💬 🗨️ 🤫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3454 pointer_traits::pointer_to should be constexpr

2 participants