Skip to content

Implement LWG-4312 Const and value category mismatch for allocator_arg_t/allocator_arg in the description of uses-allocator construction#5904

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
frederick-vs-ja:lwg-4312
Nov 27, 2025

Conversation

@frederick-vs-ja
Copy link
Contributor

Fixes #5866.

Note that the difference between allocator_arg/allocator_arg_t{} is only observable for (contrived) user-defined types, so we only need to modify _Tuple_val and _Uses_alloc_construct_non_pair (pre-C++20 only).

For scoped_allocator_adaptor and polymorphic_allocator, the changes make the pre-C++20 behavior more consistent and closer to C++20 behavior.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner November 24, 2025 10:00
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Nov 24, 2025
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Nov 24, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Nov 24, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Nov 25, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0cb7f5b into microsoft:main Nov 27, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Nov 27, 2025
@StephanTLavavej
Copy link
Member

😸 😺 🐈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-4312 Const and value category mismatch for allocator_arg_t/allocator_arg in the description of uses-allocator construction

2 participants