move_only_function: eliminate the repeated part in call specializations#5810
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Oct 29, 2025
Merged
move_only_function: eliminate the repeated part in call specializations#5810StephanTLavavej merged 2 commits intomicrosoft:mainfrom
move_only_function: eliminate the repeated part in call specializations#5810StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
StephanTLavavej
approved these changes
Oct 26, 2025
Member
|
Thanks! 😻 Verified that the divergence between script and product code is now fixed. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Oct 29, 2025
Member
|
I've resolved a trivial adjacent add-delete conflict with #5809 in |
Member
🐱 🐱 🐱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part is repeated, and can be moved into base class.
Also adjust the script to a newer preprocessor comment.
We have encapsulation by privately inheriting
_Move_only_function_call, and enablingresult_typeviausing typename _Call::result_type;, this seems unaffected.