Skip to content

Unicode 17#5803

Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
cpplearner:unicode-17
Oct 29, 2025
Merged

Unicode 17#5803
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
cpplearner:unicode-17

Conversation

@cpplearner
Copy link
Contributor

  • Fix a bug in _GB9c_regex: It incorrectly switched to the initial state when there are two adjacent Consonant characters.
    • I've renamed the _State_t enumerators to make them indicate what is seen, instead of what is expected. This is IMO clearer, and matches _GB11_LeftHand_regex.
  • Regenerate __msvc_format_ucd_tables.hpp and P0645R10_text_formatting_grapheme_clusterization\test.cpp.

Fixes #5787

@cpplearner cpplearner requested a review from a team as a code owner October 24, 2025 19:07
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Oct 24, 2025
@StephanTLavavej StephanTLavavej added enhancement Something can be improved format C++20/23 format labels Oct 24, 2025
@StephanTLavavej StephanTLavavej self-assigned this Oct 24, 2025
@StephanTLavavej
Copy link
Member

Excellent, thank you! 😻 I double-checked the generated files.

@StephanTLavavej StephanTLavavej removed their assignment Oct 24, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Oct 24, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Oct 28, 2025
@StephanTLavavej StephanTLavavej merged commit b439695 into microsoft:main Oct 29, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Oct 29, 2025
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug and upgrading our Unicode again! 🌏 🌎 🌍

@cpplearner cpplearner deleted the unicode-17 branch October 31, 2025 08:39
@cpplearner cpplearner restored the unicode-17 branch October 31, 2025 08:39
@cpplearner cpplearner deleted the unicode-17 branch October 31, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved format C++20/23 format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<format>: Unicode 17

2 participants