Add missing Mandates for resize_and_overwrite#5695
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom Sep 10, 2025
Merged
Add missing Mandates for resize_and_overwrite#5695StephanTLavavej merged 4 commits intomicrosoft:mainfrom
resize_and_overwrite#5695StephanTLavavej merged 4 commits intomicrosoft:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
e233688 to
c761d14
Compare
StephanTLavavej
approved these changes
Sep 6, 2025
Member
|
Thanks! 😻 I pushed very minor changes. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed |
Member
|
Thanks for noticing and fixing this missing enforcement! 🎉 🚀 🐱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, MSVC STL hasn't implemented the Mandates in [string.capacity]/8:
As a result, the following ill-formed program is accepted (Godbolt link):
This PR adds the missing
static_assertand expands coverage for GH-2524 to all supported (cv-unqualified) integer-like types.